Fix processing errors being caught and logged as a warning rather than failing the workflow run. #1055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisgavin
force-pushed
the
fix-status-error-being-caught
branch
from
517bc2f
to
1fc7ebc
Compare
…n failing the workflow run.
chrisgavin
force-pushed
the
fix-status-error-being-caught
branch
from
1fc7ebc
to
366e88c
Compare
henrymercer
approved these changes
May 3, 2022
This was referenced May 10, 2022
This was referenced Apr 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The catch block here was intended to mean the workflow doesn't fail if the GitHub API is unreachable, but it also has the side effect of converting the processing errors into warnings.
If there definitively are processing errors I think we want to fail the workflow to make them more obvious.
Merge / deployment checklist