Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert polynomial coefficient type to use modarith #1096

Draft
wants to merge 45 commits into
base: main
Choose a base branch
from
Draft

Convert polynomial coefficient type to use modarith #1096

wants to merge 45 commits into from
+1,301 −907

Conversation

j2kun
Copy link
Collaborator

@j2kun j2kun commented Nov 16, 2024 •
edited
Loading

TODO:

  • Add verifiers to ensure polynomial leading term and monomial op use the correct AnyType
  • Refactor PolynomialToStandard to make type management less chaotic

@j2kun j2kun marked this pull request as draft November 16, 2024 01:16
@j2kun j2kun force-pushed the polynomial-anytype branch 2 times, most recently from 3b3cff8 to f962e3e Compare November 19, 2024 05:13
@j2kun j2kun mentioned this pull request Nov 19, 2024
Merged
@j2kun j2kun force-pushed the polynomial-anytype branch 2 times, most recently from 3a71467 to beab499 Compare November 20, 2024 07:14
@j2kun
update mlir::polynomial -> mlir::heir::polynomial and start migrating
05e1775
@j2kun
migrate polynomial off coefficientType
c4f1a69
@j2kun
migrate tests off coefficientType
c6f7cd0
@j2kun
copy some more tests from upstream
3210e8f
@j2kun
modarith -> mod_arith
80cf66d
@j2kun
try fixing polynomial patterns and op arg types
07e6b11
@j2kun
fix some more tests
994afa7
@j2kun
fix lwe-to-polynomial conversion
a8b06c6
@j2kun
fix polynomial fromtensor builders and verifiers
c914b60
@j2kun
fix tests broken by syntax or missing mod_arith dep
4eb3d34
@j2kun
fix more tests for mod_arith check lines
3c977c6
@j2kun
fix a test for from_tensor type change
3f740c2
@j2kun
fix mod_arith conversions in ntt benchmark
ef43489
@j2kun
fix canonicalization test and use signed printer
28488f8
@j2kun
fix two tests to align from_tensor types
e9bfece
@j2kun
change test from a parser error to an impl-needs-update error
3bb2c87
@j2kun
fix LWEToPolynomial
26839f8
@j2kun
fix bad regex breaking test
3d5d4ea
@j2kun
start fixing polynomial-to-llvm
94e9756
@j2kun
fix lower_add, lower constant and add to mod_arith
d462816
@j2kun
mod_arith.mod_arith -> mod_arith.int
49a7a9b
@j2kun
fix storage type on two tests
c4842e2
@j2kun
allow toTensor to use AnyType for elt ty
54e24e5
@j2kun
add mod_arith lowering to poly-to-llvm pipeline
db1878e
@j2kun
migrate lower_mul
793aceb
@j2kun
lower ModArith.constant, convert lower_mul_runner
69f47e3
@j2kun
fix some, but not all, lower_mul runner tests
408890c
@j2kun
fix lower_ntt_perf_runner
b174779
@j2kun
fix ntt_benchmark
7b20069
@j2kun
Fix more tests by removing sub canonicalization
239fabb 
Replacing x-y with x + -1*y started breaking things because the constant
-1, when inserted into a mod arith type as a mod_arith.constant, was
being represented internally as -1 : i32, which for test_mul_1 caused it
to be one larger than the modulus (which was 2**31 - 1), i.e., zero,
which resulted in an infinite loop.
@j2kun
fix materialization of negative constants
e20d695
@j2kun
fix remaining tests
9bef19e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZenithalHourlyRate ZenithalHourlyRate ZenithalHourlyRate left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@j2kun @ZenithalHourlyRate