Fix Background and fit property fixes #268

[verbeeksteven]

Fixes #268

[sherwinski]

Hey @verbeeksteven, thanks for pointing this out and opening a PR. As you pointed out it looks like we are unintentionally hardcoding the fit parameter to crop, which should not be the case. I'd like to work on top of your changes to add some tests and do some general clean up for our linter before merging. I'll be sure to tag you if you'd like to review it beforehand as well.

[verbeeksteven]

@sherwinski Yup! I wasn't sure if there was something else you wanted done. You are more then welcome to adjust/do what ever you want with my PR :)

[verbeeksteven]

Any update @sherwinski I can make adjustments if you want.

[sherwinski]

Hi @verbeeksteven thanks for following up and sorry for the hold up, the last week has been a bit busy.
If possible, could you please make adjustments to your PR by following this repo's pull request guide. More specifically, you will want to pay attention to the bug fix checklist. This will help us a lot with documentation and should fix any commit-lint issues we have before merging.
Thanks again for all your help so far!

[sherwinski]

If I could suggest tweaking things here for cleanliness:

const renderedSrc = (() => {
   const srcOptions = {
     fit: "crop",
     ...imgixParams,
     ...(disableLibraryParam ? {} : { ixlib: `react-${PACKAGE_VERSION}` }),
     width,
     height,
     dpr
   };

   return constructUrl(src, srcOptions);
 })();

[sherwinski]

Hey @verbeeksteven sorry for the silence on this PR but don't worry, I did not forget about you! I am going to fix this issue as part of a separate PR, mostly to sidestep issues with prettier but also to add tests and whatnot. I'd love to add you as a reviewer if you'd like to take a look at the end result. Feel free to comment back with any questions.

[verbeeksteven]

I haven't had a ton of time to do it either, I will certain test out any edits you do though!