-
Notifications
You must be signed in to change notification settings - Fork 172
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Bazel Installation during Travis Build #122
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easyCZ
approved these changes
Oct 14, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, one minor nit.
.travis.yml
Outdated
@@ -31,8 +31,11 @@ cache: | |||
directories: | |||
- node_modules | |||
before_install: | |||
- wget https://github.com/bazelbuild/bazel/releases/download/0.11.0/bazel_0.11.0-linux-x86_64.deb | |||
- sudo dpkg -i bazel_0.11.0-linux-x86_64.deb | |||
- BAZEL_VERSION=0.11.0 \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be possible to use the list
style yaml for these? Ie.
- BAZEL_VERSION=...
- wget https://github.com/bazelbuild/bazel/releases/download/${BAZEL_VERSION}/${BAZEL_DEB}
- sudo dpkg -i ${BAZEL_DEB}
- rm ${BAZEL_DEB}
It makes a bit easier to follow what is going on
coltonmorris
pushed a commit
to coltonmorris/ts-protoc-gen
that referenced
this pull request
Oct 17, 2018
* upstream/master: Transport member of ServiceClientOptions should be optional (improbable-eng#125) Allow canceling unary calls (improbable-eng#124) CI should check that generated code has been committed (improbable-eng#127) Bumped to v0.7.8-pre (improbable-eng#123) Prepare 0.7.7 release (improbable-eng#112) Clean up Bazel Installation during Travis Build (improbable-eng#122) Don't deploy .deb files to npm (improbable-eng#121) Fix snake_cased oneof message are generated to incorrect types (improbable-eng#118) Make ServiceError optionally null (improbable-eng#116) Be explicit about the need for a CommonJS environment. (improbable-eng#108) Replace usage of `Object.assign` (improbable-eng#110) Add hint for Windows users (improbable-eng#107) Collapse Bazel Instructions in README (improbable-eng#106) Implement Client Streaming and BiDi Streaming for grpc-web (improbable-eng#82) Add support for jstype annotation (improbable-eng#104)
chrisgervang
pushed a commit
to chrisgervang/flowtype-protoc-gen
that referenced
this pull request
Nov 14, 2018
* Clean up Bazel Installation during Travis Build * Fixup build steps * Remove trailing slashes * Remove bazel deb :P
chrisgervang
added a commit
to chrisgervang/flowtype-protoc-gen
that referenced
this pull request
Nov 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.