Merge pull request #78 from invenia/gm/identity

Add method for IdentityScaling
invenia · Apr 14, 2021 · aa43348 · aa43348 · glennmoy · Apr 14, 2021
2 parents 55e3c1a + e9478f5
commit aa43348
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 1 deletion.
diff --git a/Project.toml b/Project.toml
@@ -1,7 +1,7 @@
 name = "FeatureTransforms"
 uuid = "8fd68953-04b8-4117-ac19-158bf6de9782"
 authors = ["Invenia Technical Computing Corporation"]
-version = "0.3.1"
+version = "0.3.2"
 
 [deps]
 Dates = "ade2ca70-3891-5945-98fb-dc099432e06a"

diff --git a/src/scaling.jl b/src/scaling.jl
@@ -11,6 +11,7 @@ abstract type AbstractScaling <: Transform end
 Represents the no-op scaling which simply returns the `data` it is applied on.
 """
 struct IdentityScaling <: AbstractScaling end
+IdentityScaling(args...) = IdentityScaling()
 
 @inline _apply(x, ::IdentityScaling; kwargs...) = x
 

diff --git a/test/scaling.jl b/test/scaling.jl
@@ -4,6 +4,11 @@
         scaling = IdentityScaling()
         @test scaling isa Transform
 
+        @testset "Arguments do nothing" begin
+            @test IdentityScaling(123) == IdentityScaling()
+            @test IdentityScaling([1, 2, 3]) == IdentityScaling()
+        end
+
         @testset "Vector" begin
             x = [1., 2., 3.]
             expected = [1., 2., 3.]