Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for IdentityScaling #78

Merged
merged 1 commit into from
Apr 14, 2021
Merged

Add method for IdentityScaling #78

merged 1 commit into from
Apr 14, 2021

Conversation

glennmoy
Copy link
Member

MeanStdScaling expects to be initialised with some data.
In downstream processes, MeanStdScaling might be swapped out for an IdentityScaling, so it needs to support the same construction, even if it does nothing.

MeanStdScaling expects to be initialised with some data.
In downstream processes, MeanStdScaling might be swapped out
for an IdentityScaling, so it needs to support the same
construction, even if it does nothing.
@glennmoy glennmoy enabled auto-merge April 14, 2021 18:28
@codecov
Copy link

codecov bot commented Apr 14, 2021

Codecov Report

Merging #78 (e9478f5) into main (55e3c1a) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   99.09%   99.10%           
=======================================
  Files          10       10           
  Lines         111      112    +1     
=======================================
+ Hits          110      111    +1     
  Misses          1        1           
Impacted Files Coverage Δ
src/scaling.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55e3c1a...e9478f5. Read the comment docs.

@glennmoy glennmoy merged commit aa43348 into main Apr 14, 2021
@glennmoy glennmoy deleted the gm/identity branch April 14, 2021 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants