-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes outdated sensor data after reset #1276
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
Signed-off-by: Kelly Guo <[email protected]>
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_env.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/envs/manager_based_rl_env.py
Show resolved
Hide resolved
source/extensions/omni.isaac.lab/omni/isaac/lab/sim/simulation_context.py
Outdated
Show resolved
Hide resolved
From an understanding standpoint, if a user sets robot state for articulation, isn't the base pose also updated in non-rendering sensors because the "views" capture the same memory. What does the update fabric do? 👀 Also can we have some sort of test to make sure this behavior is always verified (for sensors)? |
@@ -464,11 +472,7 @@ def render(self, mode: RenderMode | None = None): | |||
self.set_setting("/app/player/playSimulations", True) | |||
else: | |||
# manually flush the fabric data to update Hydra textures | |||
if self._fabric_iface is not None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm this would break non env workflows where users didn't need to call a forward function. Maybe we add a flag on whether forward was called and in-case it wasn't, we do it implicitly?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This shouldn't actually change any logic right? It's just moving a piece of the code into a method.
I think it's needed for capturing updates from the dof states and propagating those to the bodies. Added a test case for it. |
Signed-off-by: Kelly Guo <[email protected]>
…into sensor_reset
Description
This change adds a call to
update_articulations_kinematic()
after performing reset in an environment to ensure that non-render sensors are updated after performing reset.Type of change
Checklist
pre-commit
checks with./isaaclab.sh --format
config/extension.toml
fileCONTRIBUTORS.md
or my name already exists there