-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix patterns field check when field empty and not required #34124
Conversation
This comment was marked as abuse.
This comment was marked as abuse.
For JS, we all know that we should ping @dgrammatiko or @Fedik. It's not secret. So no, you are not the one started that trend :D . |
This comment was marked as abuse.
This comment was marked as abuse.
I hope @dgrammatiko allows ICMP Echo requests, otherwise we have to cc him :)))) |
@Ruud68 looks fine. FWIW HTML5 pattern validation was introduced in 2016 with #13094 and with the reasonable expectation that Joomla 4 will use it in every form. Obviously, this didn't happen and it's not down to the JS devs bus factor but rather to the fact that many devs introduce modern patterns (pun intended) but nobody is willing to follow them (in this case editing the XML files and adding the appropriate |
This comment was marked as abuse.
This comment was marked as abuse.
I have tested this item ✅ successfully on 7c0fd21 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34124. |
Thanks for testing @joomdonation |
I have tested this item ✅ successfully on 7c0fd21 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34124. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34124. |
Thanks for testing and RTC @Quy |
* [4.0] Notification icons (#34226) * remove method allow parent to run (#34118) Co-authored-by: Richard Fath <[email protected]> * [4.0] Changing title to tooltip for template preview (#33292) * [4.0] Changing title to tooltip fpr template preview * Update location path in description (#34238) * Fix patterns field check when field empty and not required (#34124) * [4.0] Finish transition from CSS classes "label-" to "alert-" for the pre-update check (#34227) * [4.0] mod_popular with disabled hits (#34257) * [4.0] mod_popular with disabled hits When hits are disabled for articles it makes no sense to display the Most Read Articles module in the site or admin as the contents will never be updated. This PR changes the output of the module so that instead of a list of non-updating articles a message is displayed. * [4.0] Use MVCFactory to create model (#34092) * Use MVCFactory to create models * CS * Fix row selecting, when module is disabled (#34273) * Media web service implementation. * Media web service implementation. * Fix hard coded adapter name default. * Fix missing url and tempUrl attributes in single item response. * Remove useless comments. * Replace 'PATH' with 'STRING' for cleaning of input parameters. * Adds required parameter checks and removes global exception handling. * Adds media web service specific language strings. * Adds exception handling. * Adds missing exception handler and fixes wrong path return value after move/rename. * Use exception message as error title. * Adds proper FileNotFound exception handling for GET requests. * Fixes handling of status code. * Fixes some types, formatting and similar stuff. * Fixes yet another sloppy typo. * restore file * Fix some docs * Adapter endpoint * Add plugin to install file * Add tests * Update api/components/com_media/src/Helper/MediaHelper.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Helper/MediaHelper.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/MediumModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/View/Media/JsonapiView.php Co-authored-by: Phil E. Taylor <[email protected]> * Update libraries/src/Error/JsonApi/SaveExceptionHandler.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Controller/MediaController.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Controller/MediaController.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/AdaptersModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <[email protected]> * docs * Update api/components/com_media/src/View/Media/JsonapiView.php Co-authored-by: Phil E. Taylor <[email protected]> * int * cs * cs * more cleanup * tabs * restore * Test all endpoints * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Hardening * Tests fix for drone * Update Api.php * Create directory in test with correct permissions * Add more tests and remove static helper * Update tests/Codeception/api/com_media/MediaCest.php Co-authored-by: Phil E. Taylor <[email protected]> * Update tests/Codeception/_support/Helper/Api.php Co-authored-by: Phil E. Taylor <[email protected]> * cs Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: Phil E. Taylor <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: infograf768 <[email protected]> Co-authored-by: Quy <[email protected]> Co-authored-by: Ruud <[email protected]> Co-authored-by: Tuan Pham Ngoc <[email protected]> Co-authored-by: Fedir Zinchuk <[email protected]> Co-authored-by: Pieter-Jan de Vries <[email protected]>
Pull Request for Issue #34102 .
Summary of Changes
validating pattern fails when field is not required and empty, this is not correct. This PR fixes this (in line with J3 validation)
pinging @dgrammatiko
Testing Instructions
see #34102
Actual result BEFORE applying this Pull Request
saving form with empty field is not possible
Expected result AFTER applying this Pull Request
saving form with empty field works correct
Documentation Changes Required
no