[4.0] Notification icons #34226
Merged
[4.0] Notification icons #34226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The order of the notification icons on the dashboard is determined by the order of the quickicon plugins This PR changes the order based on importance - so that Joomla Update is first. Note that phpversioncheck is last because it is not displayed in the notifications section but in the messages. Note this is for new installs only as a user could have customised the ordering themselves
|
I have tested this item ✅ successfully on 04ab84a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34226. |
1 similar comment
|
I have tested this item ✅ successfully on 04ab84a This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34226. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34226. |
Quy
added
PR-4.0-dev
RTC
|
Thanks |
bembelimen
pushed a commit
that referenced
this pull request
Nov 23, 2021
* [4.0] Notification icons (#34226) * remove method allow parent to run (#34118) Co-authored-by: Richard Fath <[email protected]> * [4.0] Changing title to tooltip for template preview (#33292) * [4.0] Changing title to tooltip fpr template preview * Update location path in description (#34238) * Fix patterns field check when field empty and not required (#34124) * [4.0] Finish transition from CSS classes "label-" to "alert-" for the pre-update check (#34227) * [4.0] mod_popular with disabled hits (#34257) * [4.0] mod_popular with disabled hits When hits are disabled for articles it makes no sense to display the Most Read Articles module in the site or admin as the contents will never be updated. This PR changes the output of the module so that instead of a list of non-updating articles a message is displayed. * [4.0] Use MVCFactory to create model (#34092) * Use MVCFactory to create models * CS * Fix row selecting, when module is disabled (#34273) * Media web service implementation. * Media web service implementation. * Fix hard coded adapter name default. * Fix missing url and tempUrl attributes in single item response. * Remove useless comments. * Replace 'PATH' with 'STRING' for cleaning of input parameters. * Adds required parameter checks and removes global exception handling. * Adds media web service specific language strings. * Adds exception handling. * Adds missing exception handler and fixes wrong path return value after move/rename. * Use exception message as error title. * Adds proper FileNotFound exception handling for GET requests. * Fixes handling of status code. * Fixes some types, formatting and similar stuff. * Fixes yet another sloppy typo. * restore file * Fix some docs * Adapter endpoint * Add plugin to install file * Add tests * Update api/components/com_media/src/Helper/MediaHelper.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Helper/MediaHelper.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/MediumModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/View/Media/JsonapiView.php Co-authored-by: Phil E. Taylor <[email protected]> * Update libraries/src/Error/JsonApi/SaveExceptionHandler.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Controller/MediaController.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Controller/MediaController.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/AdaptersModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <[email protected]> * docs * Update api/components/com_media/src/View/Media/JsonapiView.php Co-authored-by: Phil E. Taylor <[email protected]> * int * cs * cs * more cleanup * tabs * restore * Test all endpoints * Update api/components/com_media/src/Model/MediaModel.php Co-authored-by: Phil E. Taylor <[email protected]> * Hardening * Tests fix for drone * Update Api.php * Create directory in test with correct permissions * Add more tests and remove static helper * Update tests/Codeception/api/com_media/MediaCest.php Co-authored-by: Phil E. Taylor <[email protected]> * Update tests/Codeception/_support/Helper/Api.php Co-authored-by: Phil E. Taylor <[email protected]> * cs Co-authored-by: Brian Teeman <[email protected]> Co-authored-by: Phil E. Taylor <[email protected]> Co-authored-by: Richard Fath <[email protected]> Co-authored-by: infograf768 <[email protected]> Co-authored-by: Quy <[email protected]> Co-authored-by: Ruud <[email protected]> Co-authored-by: Tuan Pham Ngoc <[email protected]> Co-authored-by: Fedir Zinchuk <[email protected]> Co-authored-by: Pieter-Jan de Vries <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The order of the notification icons on the dashboard is determined by the order of the quickicon plugins
This PR changes the order based on importance - so that Joomla Update is first.
Note that phpversioncheck is last because it is not displayed in the notifications section but in the messages.
Note this is for new installs only as a user could have customised the ordering themselves
Testing Instructions
Code review