[4.0] Fix row selecting, when module is disabled

[Fedik]

Fix for #30798

Summary of Changes

Fixing incorrect selection when clicking on the row with disabled module.
This enable check box for disabled module, the same behavior as for Menu item when component is disabled.

Testing Instructions

Create Custom HTML Module. (or any other unlocked module)
Go to extension manager and disable "Custom Module".
Go back to module overview, and try select this module.

Actual result BEFORE applying this Pull Request

The next row will be selected. You cannot delete "disabled" record.

Expected result AFTER applying this Pull Request

A correct row will be selected. You able to delete "disabled" record.

Documentation Changes Required

nope

[infograf768]

I have tested this item ✅ successfully on d285cd2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34273.}

[chmst]

This resolves the drag and drop issue. But I'd prefer to remove the link to the module for editing

[Fedik]

There no reason for it.

It like editing Unpublished/Outdated Article, it still fine.

[infograf768]

No reason indeed, but if we want, the code would be something like:
line 133-155

<th scope="row" class="has-context">
							<div>
								<?php if ($item->enabled == 0) : ?>
									<?php echo $this->escape($item->title); ?>
								<?php else : ?>
									<?php if ($item->checked_out) : ?>
										<?php echo HTMLHelper::_('jgrid.checkedout', $i, $item->editor, $item->checked_out_time, 'modules.', $canCheckin); ?>
									<?php endif; ?>
									<?php if ($canEdit) : ?>
										<a href="<?php echo Route::_('index.php?option=com_modules&task=module.edit&id=' . (int) $item->id); ?>" title="<?php echo Text::_('JACTION_EDIT'); ?> <?php echo $this->escape($item->title); ?>">
											<?php echo $this->escape($item->title); ?></a>
									<?php else : ?>
										<?php echo $this->escape($item->title); ?>
									<?php endif; ?>
								<?php endif; ?>

								<?php if (!empty($item->note)) : ?>
									<div class="small">
										<?php echo Text::sprintf('JGLOBAL_LIST_NOTE', $this->escape($item->note)); ?>
									</div>
								<?php endif; ?>
							</div>
						</th>

[richard67]

@Fedik Does this solve issue #30798 completely so the issue can be closed?

[Quy]

I have tested this item ✅ successfully on d285cd2

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34273.}

[richard67]

RTC

---

_{This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/34273.}

[infograf768]

tks