Add selectNode helper to ember-node and improve types #1188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
piemonkey
force-pushed
the
feat/ember-node-select
branch
from
ef67ec6 to
321de5f
Compare
This was referenced Apr 29, 2024
The previous fix to 1.0.1 was only done due to incorrect peerDeps of ember-focus-trap, which claim that ember-source `^4.0.0 || ^5.0.0` is needed. See josemarluedke/ember-focus-trap#82
abeforgit
approved these changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
I noticed that many of the variable plugin nodes as well as image nodes have a copy-pasted version of this that I wanted to copy-paste into the snippet placeholder, so moved it here instead. I then noticed that there was a modifier to do this that wasn't being used. Since the node args are already a kind of public api for ember nodes, I thought it was better to keep that than switch to the modifier instead.
connected issues and PRs:
Done as part of the snippet placeholder work: https://binnenland.atlassian.net/browse/GN-4782
Setup
N/A
How to test/reproduce
Image nodes still work as expected. Can also be tested as part of the snippet placeholder PR when that lands.
Challenges/uncertainties
N/A
Checks PR readiness