Add snippet-placeholder node and insert menu entry #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
piemonkey
force-pushed
the
feat/snippet-placeholder
branch
4 times, most recently
from
9f13e27 to
a4bbe84
Compare
piemonkey
force-pushed
the
feat/snippet-placeholder
branch
from
a4bbe84 to
773984e
Compare
dkozickis
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Add the snippet placeholder insert control to RB.
connected issues and PRs:
binnenland.atlassian.net/browse/GN-4782
Uses: lblod/ember-rdfa-editor#1188
And: lblod/ember-rdfa-editor-lblod-plugins#419
Setup
N/A
How to test/reproduce
Should be able to insert a placeholder into a template, choosing the snippet lists, then insert a snippet in place of it. Also interesting to test alongside the equivalent GN branch.
Challenges/uncertainties
N/A
Checks PR readiness