New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added the test cases for revoking the application on gitlab and proper message is displayed for member access request in todo. #156

Open

arush-vashishtha wants to merge 2 commits into mattermost:main from Brightscout:gitlab_revoke_application

Contributor

arush-vashishtha commented Jan 16, 2024

Summary

The following PR consists the test cases for the following scenarios,

Revoking the application on Gitlab.
Display proper message for member access request in todo in RHS of Gitlab on MM.

arush-vashishtha added 2 commits

January 16, 2024 18:37


          [MM-54]: Added the test cases for revoking the application on gitlab …

…and proper message is displayed for member access request in todo. (#27)

* [MM-54]: Added the test cases for revoking the application on gitlab.

* [MM-54]: added the file for PR 407.

* [MM-54]: fixed the comments by Aayush.

* [MM-54]: fixed the comments by Aayush'

* [MM-54]: Fixed the comments by Raghav.

* [MM-54]: replaced private with public for projects/groups on gitlab.


          Merge branch 'main' into gitlab_revoke_application

6930ae9

Contributor Author

arush-vashishtha commented Jan 16, 2024

@DHaussermann @saturninoabril Can you please have a look at this?

lindalumitchell added the 2: QA Review label

DHaussermann self-requested a review

May 3, 2024 17:00

Contributor

DHaussermann commented May 3, 2024

This looks good @arush-vashishtha . It's nice to see coverage this deep on the functionality.

The script is fine. I will approve for merge once I confirm if we need any further validation of the Zephyr test data.

saturninoabril requested changes

View reviewed changes

Member

saturninoabril left a comment

Thanks @arush-vashishtha, overall looks good except for few suggestions.

data/test-cases/plugins/gitlab/sidebar/merge_request.md

@@ @@ -0,0 +1,50 @@ @@
+              ---
+              # (Required) Ensure all values are filled up
+              name: "Merge request message is rendered properly in the RHS of gitlab on MM"

Member

saturninoabril May 8, 2024

Suggested change

      
            name: "Merge request message is rendered properly in the RHS of gitlab on MM"
          
            name: "Merge request message is rendered properly in the RHS"

data/test-cases/plugins/gitlab/sidebar/merge_request.md

Comment on lines +35 to +50

+              **Step 1**
+. Generate a access request to your desired public project/group from another user on Gitlab.
+. Navigate to MM and click on the `To-do list` icon in the LHS menu on MM.
+. Check the desired member access request in the RHS of `To-do list` on MM.
+              **Step 2**
+. Accept or reject any desired member access request on Gitlab.
+. Navigate to MM and click on the `To-do list` icon in the LHS menu on MM.
+. Check the desired member access request in the RHS of `To-do list` on MM.
+              **Expected**
+              The member access request to the desired public project/group should be shown with proper description of the request and in proper UI in the RHS of Gitlab on MM.
+              After step 2, the desired member access request should be removed from the `To-do list` in RHS of Gitlab on MM.

Member

saturninoabril May 8, 2024

Please organize the steps/expected format as commented here - #161 (review)

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md

@@ @@ -0,0 +1,57 @@ @@
+              ---
+              # (Required) Ensure all values are filled up
+              name: "Refresh the sidebar after revoking the application from the gitlab."

Member

saturninoabril May 8, 2024

Suggested change

      
            name: "Refresh the sidebar after revoking the application from the gitlab."
          
            name: "Refresh the sidebar after revoking the application from GitLab"

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md


		Step 1

		1. Revoke the OAuth token for your app from the connected gitlab account.

Member

saturninoabril May 8, 2024

Suggested change

      
            1. Revoke the OAuth token for your app from the connected gitlab account.
          
            1. Revoke the OAuth token for your app from the connected GitLab account.

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md

+              **Step 1**
+. Revoke the OAuth token for your app from the connected gitlab account.
+. Navigate to MM and click on the refresh button in the LHS of gitlab.

Member

saturninoabril May 8, 2024

Suggested change

      
            2. Navigate to MM and click on the refresh button in the LHS of gitlab.
          
            2. Navigate to MM and click on the refresh button in the LHS of GitLab.

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md

+              **Step 3**
+. Revoke the OAuth token for your app from the connected gitlab account.
+. Navigate to MM and enter any slash command that fetches the data from the gitlab.

Member

saturninoabril May 8, 2024

Suggested change

      
            2. Navigate to MM and enter any slash command that fetches the data from the gitlab.
          
            2. Navigate to MM and enter any slash command that fetches the data from GitLab.

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md

+. Revoke the OAuth token for your app from the connected gitlab account.
+. Navigate to MM and enter any slash command that fetches the data from the gitlab.
+. Open the DM from Gitlab bot.

Member

saturninoabril May 8, 2024

Suggested change

      
            3. Open the DM from Gitlab bot.
          
            3. Open the DM from GitLab bot.

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md


		Expected

		All the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.

Member

saturninoabril May 8, 2024

Suggested change

      
            All the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
          
            All the GitLab icons in the LHS should be removed and the user should get a message in the DM from GitLab bot that their account has been disconnected on MM.

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md

+              **Expected**
+              All the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
+              After step 2, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.

Member

saturninoabril May 8, 2024

Suggested change

      
            After step 2, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
          
            After step 2, all the GitLab icons in the LHS should be removed and the user should get a message in the DM from GitLab bot that their account has been disconnected on MM.

data/test-cases/plugins/gitlab/sidebar/refresh_sidebar_after_revoke.md

+              All the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
+              After step 2, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
+              After step 3, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.

Member

saturninoabril May 8, 2024

Suggested change

      
            After step 3, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM. 
          
            After step 3, all the GitLab icons in the LHS should be removed and the user should get a message in the DM from GitLab bot that their account has been disconnected on MM.

Member

saturninoabril May 8, 2024

Please organize the steps/expected format as commented here - #161 (review)

Contributor

DHaussermann commented May 8, 2024

/update-branch

Contributor

DHaussermann commented May 8, 2024

@arush-vashishtha can you also try bringing your branch current to see if GitHub shows a pipeline running?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels