Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the test cases for revoking the application on gitlab and proper message is displayed for member access request in todo. #156

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 50 additions & 0 deletions data/test-cases/plugins/gitlab/sidebar/merge_request.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,50 @@
---
# (Required) Ensure all values are filled up
name: "Merge request message is rendered properly in the RHS of gitlab on MM"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Merge request message is rendered properly in the RHS of gitlab on MM"
name: "Merge request message is rendered properly in the RHS"

status: Active
priority: Normal
folder: Sidebar
authors: "@arush-vashishtha"
team_ownership: []
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)

# (Optional)
location: null
component: null
tags: []
labels: []
tested_by_contributor: null

# (Optional) Test type and tools
cypress: null
detox: null
mmctl: null
playwright: null
rainforest: []
manual_test_environments: []

# Do not change
id: null
key: null
created_on: null
last_updated: null
case_hashed: null
steps_hashed: null
---

**Step 1**

1. Generate a access request to your desired public project/group from another user on Gitlab.
2. Navigate to MM and click on the `To-do list` icon in the LHS menu on MM.
3. Check the desired member access request in the RHS of `To-do list` on MM.

**Step 2**

1. Accept or reject any desired member access request on Gitlab.
2. Navigate to MM and click on the `To-do list` icon in the LHS menu on MM.
3. Check the desired member access request in the RHS of `To-do list` on MM.

**Expected**

The member access request to the desired public project/group should be shown with proper description of the request and in proper UI in the RHS of Gitlab on MM.
After step 2, the desired member access request should be removed from the `To-do list` in RHS of Gitlab on MM.
Comment on lines +35 to +50
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please organize the steps/expected format as commented here - #161 (review)

Original file line number Diff line number Diff line change
@@ -0,0 +1,57 @@
---
# (Required) Ensure all values are filled up
name: "Refresh the sidebar after revoking the application from the gitlab."
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: "Refresh the sidebar after revoking the application from the gitlab."
name: "Refresh the sidebar after revoking the application from GitLab"

status: Active
priority: Normal
folder: Sidebar
authors: "@arush-vashishtha"
team_ownership: []
priority_p1_to_p4: P2 - Core Functions (Do core functions work?)

# (Optional)
location: null
component: null
tags: []
labels: []
tested_by_contributor: null

# (Optional) Test type and tools
cypress: null
detox: null
mmctl: null
playwright: null
rainforest: []
manual_test_environments: []

# Do not change
id: null
key: null
created_on: null
last_updated: null
case_hashed: null
steps_hashed: null
---

**Step 1**

1. Revoke the OAuth token for your app from the connected gitlab account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Revoke the OAuth token for your app from the connected gitlab account.
1. Revoke the OAuth token for your app from the connected GitLab account.

2. Navigate to MM and click on the refresh button in the LHS of gitlab.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Navigate to MM and click on the refresh button in the LHS of gitlab.
2. Navigate to MM and click on the refresh button in the LHS of GitLab.

3. Open the DM from Gitlab bot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Open the DM from Gitlab bot.
3. Open the DM from GitLab bot.


**Step 2**

1. Revoke the OAuth token for your app from the connected gitlab account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Revoke the OAuth token for your app from the connected gitlab account.
1. Revoke the OAuth token for your app from the connected GitLab account.

2. Navigate to MM and refresh the page.
3. Open the DM from Gitlab bot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Open the DM from Gitlab bot.
3. Open the DM from GitLab bot.


**Step 3**

1. Revoke the OAuth token for your app from the connected gitlab account.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Revoke the OAuth token for your app from the connected gitlab account.
1. Revoke the OAuth token for your app from the connected GitLab account.

2. Navigate to MM and enter any slash command that fetches the data from the gitlab.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
2. Navigate to MM and enter any slash command that fetches the data from the gitlab.
2. Navigate to MM and enter any slash command that fetches the data from GitLab.

3. Open the DM from Gitlab bot.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. Open the DM from Gitlab bot.
3. Open the DM from GitLab bot.


**Expected**

All the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
All the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
All the GitLab icons in the LHS should be removed and the user should get a message in the DM from GitLab bot that their account has been disconnected on MM.

After step 2, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After step 2, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
After step 2, all the GitLab icons in the LHS should be removed and the user should get a message in the DM from GitLab bot that their account has been disconnected on MM.

After step 3, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
After step 3, all the Gitlab icons in the LHS should be removed and the user should get a message in the DM from Gitlab bot that their account has been disconnected on MM.
After step 3, all the GitLab icons in the LHS should be removed and the user should get a message in the DM from GitLab bot that their account has been disconnected on MM.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please organize the steps/expected format as commented here - #161 (review)