Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 improvements #744

Merged
merged 7 commits into from
Sep 5, 2024

fix(fdc3) - Add factory methods for creating channels if necessary, f…

f6d7c38
Select commit
Loading
Failed to load commit list.
Merged

FDC3 improvements #744

fix(fdc3) - Add factory methods for creating channels if necessary, f…
f6d7c38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Sep 5, 2024 in 1s

82.92% of diff hit (target 100.00%)

View this Pull Request on Codecov

82.92% of diff hit (target 100.00%)

Annotations

Check warning on line 27 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Channels/AppChannel.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Channels/AppChannel.cs#L27 

Added line #L27 was not covered by tests

Check warning on line 26 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Converters/DisplayMetadataJsonConverter.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Converters/DisplayMetadataJsonConverter.cs#L26 

Added line #L26 was not covered by tests

Check warning on line 32 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Converters/DisplayMetadataJsonConverter.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Converters/DisplayMetadataJsonConverter.cs#L31-L32 

Added lines #L31 - L32 were not covered by tests

Check warning on line 97 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L97 

Added line #L97 was not covered by tests

Check warning on line 113 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L113 

Added line #L113 was not covered by tests

Check warning on line 117 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L117 

Added line #L117 was not covered by tests

Check warning on line 120 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L120 

Added line #L120 was not covered by tests

Check warning on line 135 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L135 

Added line #L135 was not covered by tests

Check warning on line 138 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L138 

Added line #L138 was not covered by tests

Check warning on line 144 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L142-L144 

Added lines #L142 - L144 were not covered by tests

Check warning on line 148 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L148 

Added line #L148 was not covered by tests

Check warning on line 151 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L150-L151 

Added lines #L150 - L151 were not covered by tests

Check warning on line 155 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L153-L155 

Added lines #L153 - L155 were not covered by tests

Check warning on line 157 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L157 

Added line #L157 was not covered by tests

Check warning on line 169 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L169 

Added line #L169 was not covered by tests

Check warning on line 178 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L178 

Added line #L178 was not covered by tests

Check warning on line 182 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L182 

Added line #L182 was not covered by tests

Check warning on line 184 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L184 

Added line #L184 was not covered by tests

Check warning on line 250 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L249-L250 

Added lines #L249 - L250 were not covered by tests

Check warning on line 360 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L360 

Added line #L360 was not covered by tests

Check warning on line 365 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L365 

Added line #L365 was not covered by tests

Check warning on line 375 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L375 

Added line #L375 was not covered by tests

Check warning on line 452 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L446-L452 

Added lines #L446 - L452 were not covered by tests

Check warning on line 456 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L455-L456 

Added lines #L455 - L456 were not covered by tests

Check warning on line 556 in src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs

See this annotation in the file changed.

@codecov codecov / codecov/patch

src/fdc3/dotnet/DesktopAgent/src/MorganStanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs#L556 

Added line #L556 was not covered by tests
View more details on Codecov