Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FDC3 improvements #744

Merged
merged 7 commits into from
Sep 5, 2024

fix(fdc3) - Add factory methods for creating channels if necessary, f…

f6d7c38
Select commit
Loading
Failed to load commit list.
Merged

FDC3 improvements #744

fix(fdc3) - Add factory methods for creating channels if necessary, f…
f6d7c38
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 5, 2024 in 0s

68.93% (+1.27%) compared to a75e955

View this Pull Request on Codecov

68.93% (+1.27%) compared to a75e955

Details

Codecov Report

Attention: Patch coverage is 82.92683% with 147 lines in your changes missing coverage. Please review.

Project coverage is 68.93%. Comparing base (a75e955) to head (f6d7c38).

Files with missing lines Patch % Lines
...Stanley.ComposeUI.DesktopAgent/Fdc3DesktopAgent.cs 71.70% 91 Missing and 25 partials ⚠️
...fdc3/src/infrastructure/ComposeUIIntentListener.ts 0.00% 7 Missing ⚠️
...e/Internal/Fdc3DesktopAgentMessageRouterService.cs 85.71% 4 Missing and 1 partial ⚠️
...opAgent/Converters/DisplayMetadataJsonConverter.cs 0.00% 3 Missing ⚠️
.../MorganStanley.ComposeUI.DesktopAgent/Fdc3Topic.cs 76.92% 2 Missing and 1 partial ⚠️
...dc3/js/composeui-fdc3/src/ComposeUIDesktopAgent.ts 92.10% 3 Missing ⚠️
.../src/infrastructure/MessageRouterChannelFactory.ts 97.14% 2 Missing ⚠️
...rastructure/messages/Fdc3GetUserChannelsRequest.ts 86.66% 2 Missing ⚠️
...rastructure/messages/Fdc3JoinUserChannelRequest.ts 86.66% 2 Missing ⚠️
...nley.ComposeUI.DesktopAgent/Channels/AppChannel.cs 50.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #744      +/-   ##
==========================================
+ Coverage   67.66%   68.93%   +1.27%     
==========================================
  Files         261      289      +28     
  Lines        7997     8612     +615     
  Branches      894     1012     +118     
==========================================
+ Hits         5411     5937     +526     
- Misses       2399     2462      +63     
- Partials      187      213      +26
Files with missing lines Coverage Δ
...Stanley.ComposeUI.DesktopAgent/Channels/Channel.cs 90.14% <100.00%> (+0.43%) ⬆️
....DesktopAgent/Contracts/CreateAppChannelRequest.cs 100.00% <100.00%> (ø)
...DesktopAgent/Contracts/CreateAppChannelResponse.cs 100.00% <100.00%> (ø)
...eUI.DesktopAgent/Contracts/FindInstancesRequest.cs 100.00% <100.00%> (ø)
...UI.DesktopAgent/Contracts/FindInstancesResponse.cs 100.00% <100.00%> (ø)
...UI.DesktopAgent/Contracts/GetAppMetadataRequest.cs 100.00% <100.00%> (ø)
...I.DesktopAgent/Contracts/GetAppMetadataResponse.cs 100.00% <100.00%> (ø)
...ComposeUI.DesktopAgent/Contracts/GetInfoRequest.cs 100.00% <100.00%> (ø)
...omposeUI.DesktopAgent/Contracts/GetInfoResponse.cs 100.00% <100.00%> (ø)
...I.DesktopAgent/Contracts/GetUserChannelsRequest.cs 100.00% <100.00%> (ø)
... and 34 more

... and 9 files with indirect coverage changes

View more details on Codecov