This repository has been archived by the owner on Dec 3, 2020. It is now read-only.
Fix #290: Do not allow scrollbars on the entire popup itself. #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
biancadanforth
approved these changes
Nov 28, 2018
This overflow declaration was added in mozilla#215, nominally to help deal with overflow issues when pinned to the overflow menu, but it's not clear how this particular line helps vs the other changes to the width of the onboarding view. My theory on why this is biting us now: - mozilla#256 updated the popup to a fixed width when not in the overflow menu, and a flexible width when it is. - When we have more items than the 600px max height in the popup, we overflow and add a vertical toolbar inside. - The vertical toolbar increases the desired width of the popup, causing the body element to add a horizontal scrollbar. - The horizontal scrollbar increases the height beyond the 600px limit (since the initial overflow is contained within the product listing), causing the body element to add a vertical scrollbar. If we force the body element to hide overflow, it refuses to add scrollbars, and the overflow scrollbar on the product listing is overlaid correctly. This should be safe to do now that we flex the width of the popup based on where it is located.
Osmose
force-pushed
the
scrollbars-again
branch
from
4a673dc to
9e78d8b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This overflow declaration was added in #215, nominally to help deal with
overflow issues when pinned to the overflow menu, but it's not clear how this
particular line helps vs the other changes to the width of the onboarding
view.
My theory on why this is biting us now:
flexible width when it is.
and add a vertical toolbar inside.
body element to add a horizontal scrollbar.
the initial overflow is contained within the product listing), causing the
body element to add a vertical scrollbar.
If we force the body element to hide overflow, it refuses to add scrollbars, and
the overflow scrollbar on the product listing is overlaid correctly. This should
be safe to do now that we flex the width of the popup based on where it is
located.