[docs][joy] Build TS versions for Checkbox component demos #36381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Netlify deploy previewhttps://deploy-preview-36381--material-ui.netlify.app/ Bundle size report |
zannager
added
component: checkbox
hbjORbj
changed the title
10 tasks
sai6855
commented
Mar 1, 2023
| opacity: 0.32, | ||
| }, | ||
| } | ||
| : undefined, |
There was a problem hiding this comment.
was getting below typescript error if sx is {} hence changed to undefined. Not entirely sure why it worked though
hbjORbj
suggested changes
Mar 1, 2023
| checked={value.includes(item)} | ||
| color="neutral" | ||
| variant={value.includes(item) ? 'outlined' : 'plain'} | ||
| onChange={(event) => { |
| label={item} | ||
| checked={value.includes(item)} | ||
| variant={value.includes(item) ? 'soft' : 'outlined'} | ||
| onChange={(event) => { |
There was a problem hiding this comment.
event type would be inferred right, any reason why we would need to add type explicitly?
There was a problem hiding this comment.
Because I want to keep consistency throughout Joy TS demos.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #36367