Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs][joy] Build TS versions for List component demos #36382

Merged
merged 17 commits into from
Mar 3, 2023
Merged

[docs][joy] Build TS versions for List component demos #36382

merged 17 commits into from
Mar 3, 2023

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 1, 2023

part of #36367

@mui-bot
Copy link

mui-bot commented Mar 1, 2023 •
edited
Loading

Netlify deploy preview

https://deploy-preview-36382--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against fb8fce9

@zannager zannager added component: list This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Mar 1, 2023
@zannager zannager requested a review from hbjORbj March 1, 2023 10:53
@sai6855 sai6855 marked this pull request as draft March 1, 2023 10:59
@hbjORbj hbjORbj changed the title [List][Joy] Typescript demos list [docs][joy] Build TS versions for List component demos Mar 1, 2023
@hbjORbj hbjORbj mentioned this pull request Mar 1, 2023
Closed
10 tasks
@hbjORbj
Copy link
Member

hbjORbj commented Mar 2, 2023 •
edited
Loading

Is this ready for review, or still a draft?

@sai6855
Copy link
Contributor Author

sai6855 commented Mar 2, 2023 •
edited
Loading

Is this ready for review, or still a draft?

Still in draft, I'll try to fix types by tonight

This is ready for review #36381

@sai6855 sai6855 marked this pull request as ready for review March 2, 2023 13:56
hbjORbj
hbjORbj approved these changes Mar 3, 2023
View reviewed changes
Copy link
Member

@hbjORbj hbjORbj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

@hbjORbj hbjORbj merged commit f218e7d into mui:master Mar 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hbjORbj hbjORbj hbjORbj approved these changes

Assignees
No one assigned
Labels
component: list This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai6855 @mui-bot @hbjORbj @zannager