Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[website] Link Discord in footer #38369

Merged
merged 5 commits into from
Aug 11, 2023
Merged

[website] Link Discord in footer #38369

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
0cb8a5c
[website] Adding Discord Icon on global footer
Aug 7, 2023
962936c
Update docs/src/icons/SvgDiscord.tsx
richbustos Aug 8, 2023
22f4f3d
optimize svg
oliviertassinari Aug 11, 2023
3cd3b36
use SvgIcon
oliviertassinari Aug 11, 2023
9900e70
improve Stack Overflow logo
oliviertassinari Aug 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions docs/src/icons/SvgDiscord.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
import * as React from 'react';
import RootSvg, { RootSvgProps } from 'docs/src/icons/RootSvg';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should use SvgIcon here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm having issues using SvgIcon. I don't think it's properly set up in /layout folder path because every time I import SvgIcon, I get a weird error for the fontSize prop. I even tried overriding the default prop but still got an error. I also so don't see any use-cases of SvgIcon in the /layout folder, which makes me believe that the person who implemented the StackOverflow icon on the footer had the same issue as me. Im using the same convention as SvgStackOverflow in docs/src/icons/SvgStackOverflow.

The proper way this should be handled is by adding these icons in our official Material UI Icons, but saw that it is currently not in our scope:

#35100
#19371
#35218

The Discord blog and Tweet will be going out this week and would like the footer to be ready by then. I can address the Material UI Icon and/or the SvgIcon issue after if that's okay.

Copy link
Member

@oliviertassinari oliviertassinari Aug 11, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a change with what I had in mind with my comment. It's more using Material UI "by the book".


function SvgComponent(props: RootSvgProps) {
return (
<RootSvg
viewBox="0 0 24 24"
xmlns="http://www.w3.org/2000/svg"
fill="currentColor"
width="20"
height="20"
richbustos marked this conversation as resolved.
Show resolved Hide resolved
{...props}
>
<path d="M20.317 4.3698a19.7913 19.7913 0 00-4.8851-1.5152.0741.0741 0 00-.0785.0371c-.211.3753-.4447.8648-.6083 1.2495-1.8447-.2762-3.68-.2762-5.4868 0-.1636-.3933-.4058-.8742-.6177-1.2495a.077.077 0 00-.0785-.037 19.7363 19.7363 0 00-4.8852 1.515.0699.0699 0 00-.0321.0277C.5334 9.0458-.319 13.5799.0992 18.0578a.0824.0824 0 00.0312.0561c2.0528 1.5076 4.0413 2.4228 5.9929 3.0294a.0777.0777 0 00.0842-.0276c.4616-.6304.8731-1.2952 1.226-1.9942a.076.076 0 00-.0416-.1057c-.6528-.2476-1.2743-.5495-1.8722-.8923a.077.077 0 01-.0076-.1277c.1258-.0943.2517-.1923.3718-.2914a.0743.0743 0 01.0776-.0105c3.9278 1.7933 8.18 1.7933 12.0614 0a.0739.0739 0 01.0785.0095c.1202.099.246.1981.3728.2924a.077.077 0 01-.0066.1276 12.2986 12.2986 0 01-1.873.8914.0766.0766 0 00-.0407.1067c.3604.698.7719 1.3628 1.225 1.9932a.076.076 0 00.0842.0286c1.961-.6067 3.9495-1.5219 6.0023-3.0294a.077.077 0 00.0313-.0552c.5004-5.177-.8382-9.6739-3.5485-13.6604a.061.061 0 00-.0312-.0286zM8.02 15.3312c-1.1825 0-2.1569-1.0857-2.1569-2.419 0-1.3332.9555-2.4189 2.157-2.4189 1.2108 0 2.1757 1.0952 2.1568 2.419 0 1.3332-.9555 2.4189-2.1569 2.4189zm7.9748 0c-1.1825 0-2.1569-1.0857-2.1569-2.419 0-1.3332.9554-2.4189 2.1569-2.4189 1.2108 0 2.1757 1.0952 2.1568 2.419 0 1.3332-.946 2.4189-2.1568 2.4189Z" />
oliviertassinari marked this conversation as resolved.
Show resolved Hide resolved
</RootSvg>
);
}

export default SvgComponent;
11 changes: 11 additions & 0 deletions docs/src/layouts/AppFooter.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ import EmailSubscribe from 'docs/src/components/footer/EmailSubscribe';
import ROUTES from 'docs/src/route';
import Link from 'docs/src/modules/components/Link';
import SvgStackOverflow from 'docs/src/icons/SvgStackOverflow';
import SvgDiscord from 'docs/src/icons/SvgDiscord';

interface AppFooterProps {
stackOverflowUrl?: string;
Expand Down Expand Up @@ -227,6 +228,16 @@ export default function AppFooter(props: AppFooterProps) {
<SvgStackOverflow fontSize="small" />
</IconButton>
) : null}
<IconButton
target="_blank"
rel="noopener noreferrer"
href="https://mui.com/r/discord/"
aria-label="Discord"
title="Discord"
size="small"
>
<SvgDiscord fontSize="small" />
</IconButton>
</Stack>
</Box>
</Box>
Expand Down