[GridList] Migrate to v1 branch #7626
Conversation
oliviertassinari
added
component: image list
src/GridList/GridList.js
Outdated
| /** | ||
| * Number of px for the gutter/spacing between tiles. | ||
| */ | ||
| gutter: PropTypes.number, |
There was a problem hiding this comment.
Thanks for picking up this PR. Perhaps something got lost in translation, but I thought we agreed that "gutter" was the incorrect term for this (and Grid)?
There was a problem hiding this comment.
Yes, want to change the Grid and the GridList at once latter. I would rather be consistante first.
There was a problem hiding this comment.
Hmm... okay, I guess since we're not worried about breaking changes that's one way to do it, but it surely getting it right here, and changing Grid to match (whether now or later) would still be preferable?
There was a problem hiding this comment.
@mbrookes I can do that extra work in the same PR, yes.
|
I'm almost done with the missing tests. |
|
@mbrookes Thanks for the original migration! Your hours spent in the flight has proven to worth it 👍 . |
oliviertassinari
changed the title
* [GridList] migrate to next branch * [Grid] Rename gutter into spacing
* upstream/v1-beta: [Modal] Fix with react@next (mui#7673) Typo fix 'accross' to 'across' (mui#7671) v1.0.0-beta.4 [CHANGELOG] Prepare 1.0.0-beta.4 [typescript] Improve the coverage (mui#7606) [Modal] Take into account the body margin (mui#7666) Fixes in the subway (mui#7661) [flow] export type Props for composability (mui#7609) [ButtonBase] Explicit the need for a class component (mui#7656) [Eslint] Spell check config (mui#7643) [ListItemText] Repurpose text class (mui#7645) [GridList] migrate to next branch (mui#7626) [Typo] Correct words spelling v1 (mui#7641) Update docs for <RadioGroup> (mui#7640) Fixed "initial" word
* v1-beta: [Modal] Fix with react@next (mui#7673) Typo fix 'accross' to 'across' (mui#7671) v1.0.0-beta.4 [CHANGELOG] Prepare 1.0.0-beta.4 [typescript] Improve the coverage (mui#7606) [Modal] Take into account the body margin (mui#7666) Fixes in the subway (mui#7661) [flow] export type Props for composability (mui#7609) [ButtonBase] Explicit the need for a class component (mui#7656) [Eslint] Spell check config (mui#7643) [ListItemText] Repurpose text class (mui#7645) [GridList] migrate to next branch (mui#7626) [Typo] Correct words spelling v1 (mui#7641) Update docs for <RadioGroup> (mui#7640) Fixed "initial" word
Breaking change
guttertospacing.Closes #6795 as it's a continuation
Closes #5264 as we are no longer using the paper componnent
Closes #5303 as we can use normal class name override
Closes #6194 as we don't support iOS < 10
Closes #6261 as people can use
withWidth()higher-order componentCloses #6302 as it's the migration task
Closes #7057 as it's a rewrite, in the doubt and without reproduction example, let's close