Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Modal] Take into account the body margin #7666

Merged
merged 1 commit into from
Aug 4, 2017
Merged

[Modal] Take into account the body margin #7666

merged 1 commit into from
Aug 4, 2017

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Aug 4, 2017

Closes #7657.

I have been testing on Chrome 60, Edge 15 and IE 11, all good.

  • PR has tests / docs demo, and is linted.
  • Commit and PR titles begin with [ComponentName], and are in imperative form: "[Component] Fix leaky abstraction".
  • Description explains the issue / use-case resolved, and auto-closes the related issue(s) (http://tr.im/vFqem).

@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work v1 labels Aug 4, 2017
@oliviertassinari oliviertassinari merged commit 2622388 into mui:v1-beta Aug 4, 2017
@oliviertassinari oliviertassinari deleted the modal-manager-body-margin branch August 4, 2017 20:49
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
* upstream/v1-beta:
  [Modal] Fix with react@next (mui#7673)
  Typo fix 'accross' to 'across' (mui#7671)
  v1.0.0-beta.4
  [CHANGELOG] Prepare 1.0.0-beta.4
  [typescript] Improve the coverage (mui#7606)
  [Modal] Take into account the body margin (mui#7666)
  Fixes in the subway (mui#7661)
  [flow] export type Props for composability (mui#7609)
  [ButtonBase] Explicit the need for a class component (mui#7656)
  [Eslint] Spell check config (mui#7643)
  [ListItemText] Repurpose text class (mui#7645)
  [GridList] migrate to next branch (mui#7626)
  [Typo] Correct words spelling v1 (mui#7641)
  Update docs for <RadioGroup> (mui#7640)
  Fixed "initial" word
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
* v1-beta:
  [Modal] Fix with react@next (mui#7673)
  Typo fix 'accross' to 'across' (mui#7671)
  v1.0.0-beta.4
  [CHANGELOG] Prepare 1.0.0-beta.4
  [typescript] Improve the coverage (mui#7606)
  [Modal] Take into account the body margin (mui#7666)
  Fixes in the subway (mui#7661)
  [flow] export type Props for composability (mui#7609)
  [ButtonBase] Explicit the need for a class component (mui#7656)
  [Eslint] Spell check config (mui#7643)
  [ListItemText] Repurpose text class (mui#7645)
  [GridList] migrate to next branch (mui#7626)
  [Typo] Correct words spelling v1 (mui#7641)
  Update docs for <RadioGroup> (mui#7640)
  Fixed "initial" word
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant