-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Spell check eslint script #7643
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
.eslintrc.spellcheck.js
Outdated
ecmaVersion: 7, | ||
sourceType: 'module', | ||
}, | ||
plugins: ['babel', 'import', 'jsx-a11y', 'mocha', 'flowtype', 'material-ui', 'prettier', 'spellcheck'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we just want to keep spellcheck
here?
@kybarg That's a great addition to the lib :). |
sebald
pushed a commit
to PTW-Freiburg/material-ui
that referenced
this pull request
Aug 7, 2017
* Eslint config for spell check * [Eslint] only spelling test * [Typo] fixed tests
sebald
pushed a commit
to PTW-Freiburg/material-ui
that referenced
this pull request
Aug 7, 2017
* upstream/v1-beta: [Modal] Fix with react@next (mui#7673) Typo fix 'accross' to 'across' (mui#7671) v1.0.0-beta.4 [CHANGELOG] Prepare 1.0.0-beta.4 [typescript] Improve the coverage (mui#7606) [Modal] Take into account the body margin (mui#7666) Fixes in the subway (mui#7661) [flow] export type Props for composability (mui#7609) [ButtonBase] Explicit the need for a class component (mui#7656) [Eslint] Spell check config (mui#7643) [ListItemText] Repurpose text class (mui#7645) [GridList] migrate to next branch (mui#7626) [Typo] Correct words spelling v1 (mui#7641) Update docs for <RadioGroup> (mui#7640) Fixed "initial" word
sebald
pushed a commit
to PTW-Freiburg/material-ui
that referenced
this pull request
Aug 7, 2017
* v1-beta: [Modal] Fix with react@next (mui#7673) Typo fix 'accross' to 'across' (mui#7671) v1.0.0-beta.4 [CHANGELOG] Prepare 1.0.0-beta.4 [typescript] Improve the coverage (mui#7606) [Modal] Take into account the body margin (mui#7666) Fixes in the subway (mui#7661) [flow] export type Props for composability (mui#7609) [ButtonBase] Explicit the need for a class component (mui#7656) [Eslint] Spell check config (mui#7643) [ListItemText] Repurpose text class (mui#7645) [GridList] migrate to next branch (mui#7626) [Typo] Correct words spelling v1 (mui#7641) Update docs for <RadioGroup> (mui#7640) Fixed "initial" word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now this is quite ugly and misses some errors. I think full review of css class names, vars names and functions names needed. Most of the spell error are from test as lorem impsum used.