Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Spell check eslint script #7643

Merged
merged 3 commits into from
Aug 3, 2017

Conversation

kybarg
Copy link
Contributor

@kybarg kybarg commented Aug 2, 2017

Now this is quite ugly and misses some errors. I think full review of css class names, vars names and functions names needed. Most of the spell error are from test as lorem impsum used.

ecmaVersion: 7,
sourceType: 'module',
},
plugins: ['babel', 'import', 'jsx-a11y', 'mocha', 'flowtype', 'material-ui', 'prettier', 'spellcheck'],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we just want to keep spellcheck here?

@oliviertassinari
Copy link
Member

@kybarg That's a great addition to the lib :).

@oliviertassinari oliviertassinari merged commit 2caa412 into mui:v1-beta Aug 3, 2017
@oliviertassinari oliviertassinari changed the title [Eslint] Spell check config [core] Spell check eslint script Aug 3, 2017
@oliviertassinari oliviertassinari changed the title [core] Spell check eslint script [docs] Spell check eslint script Aug 3, 2017
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Aug 3, 2017
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
* Eslint config for spell check

* [Eslint] only spelling test

* [Typo] fixed tests
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
* upstream/v1-beta:
  [Modal] Fix with react@next (mui#7673)
  Typo fix 'accross' to 'across' (mui#7671)
  v1.0.0-beta.4
  [CHANGELOG] Prepare 1.0.0-beta.4
  [typescript] Improve the coverage (mui#7606)
  [Modal] Take into account the body margin (mui#7666)
  Fixes in the subway (mui#7661)
  [flow] export type Props for composability (mui#7609)
  [ButtonBase] Explicit the need for a class component (mui#7656)
  [Eslint] Spell check config (mui#7643)
  [ListItemText] Repurpose text class (mui#7645)
  [GridList] migrate to next branch (mui#7626)
  [Typo] Correct words spelling v1 (mui#7641)
  Update docs for <RadioGroup> (mui#7640)
  Fixed "initial" word
sebald pushed a commit to PTW-Freiburg/material-ui that referenced this pull request Aug 7, 2017
* v1-beta:
  [Modal] Fix with react@next (mui#7673)
  Typo fix 'accross' to 'across' (mui#7671)
  v1.0.0-beta.4
  [CHANGELOG] Prepare 1.0.0-beta.4
  [typescript] Improve the coverage (mui#7606)
  [Modal] Take into account the body margin (mui#7666)
  Fixes in the subway (mui#7661)
  [flow] export type Props for composability (mui#7609)
  [ButtonBase] Explicit the need for a class component (mui#7656)
  [Eslint] Spell check config (mui#7643)
  [ListItemText] Repurpose text class (mui#7645)
  [GridList] migrate to next branch (mui#7626)
  [Typo] Correct words spelling v1 (mui#7641)
  Update docs for <RadioGroup> (mui#7640)
  Fixed "initial" word
@kybarg kybarg deleted the next-eslint-spellcheck branch October 11, 2018 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants