[DataGrid] Fix header filters showing clear button while empty #15829

k-rajat19 · 2024-12-10T12:50:28Z

I have followed (at least) the PR section of the contributing guide.

Closes #15778

https://deploy-preview-15829--material-ui-x.netlify.app/x/react-data-grid/filtering/header-filters/

Changelog

Breaking changes

The sanitizeFilterItemValue() utility is not exported anymore.

mui-bot · 2024-12-10T12:54:00Z

Deploy preview: https://deploy-preview-15829--material-ui-x.netlify.app/

Updated pages:

docs/data/migration/migration-data-grid-v7/migration-data-grid-v7.md

Generated by 🚫 dangerJS against 1d992fa

packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputValue.tsx

k-rajat19 · 2024-12-10T13:11:56Z

packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputValue.tsx

@@ -62,17 +75,17 @@ function GridFilterInputValue(props: GridTypeFilterInputValueProps) {

  React.useEffect(() => {
    const itemPlusTag = item as ItemPlusTag;
-    if (itemPlusTag.fromInput !== id || item.value === undefined) {
-      setFilterValueState(String(item.value ?? ''));
+    if (itemPlusTag.fromInput !== id || item.value == null) {


using == to also consider null values

I'd rather explicitly use x === null || x === undefined rather than rely on the == operator, which I think we should not use in any situation.

Thanks for the review, but x == null is only loosely equal to undefined, no matter what is in item.value. If it is not null or undefined, it always returns false. Or are there any other downsides of using == opertaor?

arminmeh · 2024-12-10T17:20:33Z

This makes another change that should not be there.
If you change the operator and clear the value in the field (with backspace) it also resets the operator.
You can check the previous behavior here

k-rajat19 · 2024-12-11T10:13:26Z

This makes another change that should not be there. If you change the operator and clear the value in the field (with backspace) it also resets the operator.

this behavior has existed in previous versions as well, this was accidentally fixed in #15528
I have now fixed it with this commit ae075dd

k-rajat19 · 2024-12-12T17:04:40Z

Hi @arminmeh ,
I'm not able to figure out why the browser test keeps failing, everything is working fine and all unit tests are passing as well.
I would like you to look into this when you have time.
The test has started failing from this commit ae075dd

arminmeh · 2024-12-13T09:14:08Z

@k-rajat19 thanks for the effort so far
I will take a look at the failing test

arminmeh · 2024-12-16T10:22:38Z

packages/x-data-grid-pro/src/components/headerFiltering/GridHeaderFilterCell.tsx

@@ -167,13 +167,9 @@ const GridHeaderFilterCell = React.forwardRef<HTMLDivElement, GridHeaderFilterCe

    const applyFilterChanges = React.useCallback(
      (updatedItem: GridFilterItem) => {
-        if (item.value && updatedItem.value === undefined) {


@mui/xgrid I have removed deletion of the filter item to avoid
#15829 (comment)

do you see any issue with this?

Question for @KenanYusuf
With this change, deleting the value with the keyboard keeps the operator, but clicking on the clear (X) button resets everything
Should this be aligned or it is fine like this?

Should this be aligned or it is fine like this?

Definitely shouldn't reset the operator with keyboard deletion. I'm not certain it should reset upon clicking the clear button either... seems a little unexpected to me 🤔

I have updated it for the clear button as well

@mui/xgrid I have removed deletion of the filter item to avoid
#15829 (comment)

do you see any issue with this?

Doing this changed the behavior of how the filter model updation works.

Here's the console.log output for the arguments passed to onFilterModelChange for the following actions.

Add a filter

Press the clear X button

Current version Updated version (this PR)

Notice the filter item still being in the filterModel, it is a breaking behavior. If we want to make this a default behavior, should we do it for other column types too? (date, singleSelect, etc.)

I'd prefer not to keep the item in the filterModel which is cleared/doesn't have a valid value.

Wdyt?

thanks for pointing it out
I assumed that the clear button was there in the first place to remove the item from the model.

The issue is that the end user does not know that this is the goal of it and sees an empty input with a clear button still present.

should we then preserve the operator in the UI only?
It can update if the filter item operator gets changed programatically
Otherwise, it will keep its last value and once you start typing again, it will add a new item with both value and the last operator

Wdyt?

should we then preserve the operator in the UI only?

IMO, it comes down to the type of interaction the user did.
For removing text letter by letter with Backspace/Delete, the operator preserved makes sense.
However, upon clearing the filter completely (X button), I would expect the filter to be deleted (including the operator).

Consider an example interaction done by a user X.

He searches for names that start from 'John' (startsFrom operator has a connection with the value)
If he made a typo, he'd backspace and retype, but if the search has been completed and another search has to be done, he'd clear the filter (X button) intending to remove the operator too.

The next filter would most likely need another operator, let's say contains. So in my opinion, resetting the filter makes sense in that case.

Does this make sense to you?

That example does make sense @MBilalShafi, but the opposite scenario is also valid, where users are not expecting the operator to reset. The results would be confusing if they re-searched and had not noticed the operator reset. I think it's a design issue, because it doesn't look like the X is associated to the filter operator. I'll bear it in mind as I'm currently experimenting on an updated design for the header filters for v8.

the opposite scenario is also valid, where users are not expecting the operator to reset.

The positioning of "X" icon right next to the text and before the operator icon makes this argument solid, indeed! Some users might associate it with only the text and be surprised on the operator reset.
I'm fine with preserving the operator in UI until we come up with a better UI design. 👍

I will update the code so that the UI keeps the state and adds both the operator and the value once the user adds the value to the header filter
For the empty value, item will be deleted from the model

Update:
To avoid adding additional complexity for syncing the state between the UI and the model, I have reverted the code to the state where backspacing does not clear the operator, but clicking on the X button does.

At first, I thought that having a filter item in the model that does not have the value would be strange but then I saw that it happens anyway if you change the operator before typing in any value.

Also it is better to not have a separate UI state since the header filters have to react to the changes made in the filter toolbar

Nitpick: Remove applyFilterChanges and pass apiRef.current.upsertFilterItem directly.

arminmeh · 2024-12-20T18:58:59Z

scripts/x-data-grid-premium.exports.json

@@ -660,7 +660,6 @@
  { "name": "renderEditSingleSelectCell", "kind": "Variable" },
  { "name": "renderRowReorderCell", "kind": "Variable" },
  { "name": "RowPropsOverrides", "kind": "Interface" },
-  { "name": "sanitizeFilterItemValue", "kind": "Variable" },


I have removed this because I have noticed that it was unnecessarily exported here

It will not be back-ported to v7

github-actions · 2024-12-23T08:58:14Z

This pull request has conflicts, please resolve those before we can evaluate the pull request.

MBilalShafi

LGTM

packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputValue.tsx

MBilalShafi · 2024-12-23T10:45:39Z

packages/x-data-grid-pro/src/components/headerFiltering/GridHeaderFilterCell.tsx

@@ -167,13 +167,9 @@ const GridHeaderFilterCell = React.forwardRef<HTMLDivElement, GridHeaderFilterCe

    const applyFilterChanges = React.useCallback(
      (updatedItem: GridFilterItem) => {
-        if (item.value && updatedItem.value === undefined) {


Nitpick: Remove applyFilterChanges and pass apiRef.current.upsertFilterItem directly.

github-actions · 2024-12-23T12:57:21Z

Cherry-pick PRs will be created targeting branches: v7.x

@josteinjhauge

commit 55b01ba Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Jan 14 20:51:13 2025 +0200 Bump MUI Internal (mui#16177) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit bdd82ae Author: Alexandre Fauquette <[email protected]> Date: Tue Jan 14 14:35:41 2025 +0100 [charts] Plot data at first render if `skipAnimation` is set to `true` (mui#16166) Signed-off-by: Alexandre Fauquette <[email protected]> Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Jose C Quintas Jr <[email protected]> commit ca63047 Author: Alexandre Fauquette <[email protected]> Date: Tue Jan 14 13:18:02 2025 +0100 [docs] Add example for custom legend (mui#16169) commit fdcc57e Author: Alexandre Fauquette <[email protected]> Date: Tue Jan 14 12:01:56 2025 +0100 [docs] Remove broken links (mui#16167) commit 7c505ea Author: Flavien DELANGLE <[email protected]> Date: Tue Jan 14 07:35:12 2025 +0100 [pickers] Let the field components handle their opening UI, and allow field editing on mobile pickers (mui#15671) Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> commit c7f8cd6 Author: Flavien DELANGLE <[email protected]> Date: Mon Jan 13 16:37:49 2025 +0100 [docs] Add full custom field creation example (mui#15194) Signed-off-by: Flavien DELANGLE <[email protected]> Signed-off-by: Lukas Tyla <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> commit aa515ec Author: Alexandre Fauquette <[email protected]> Date: Mon Jan 13 15:53:59 2025 +0100 [charts] Move z-axis to plugin (mui#16130) commit 2c9ddc9 Author: Jose C Quintas Jr <[email protected]> Date: Mon Jan 13 13:58:06 2025 +0100 [charts] Make `useChartGradientId` public (mui#16106) commit 6e76ec9 Author: Lukas Tyla <[email protected]> Date: Mon Jan 13 13:18:23 2025 +0200 [code-infra] Stop renovate from updating `date-fns-v2` (mui#16158) commit 770ab40 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 10:03:03 2025 +0200 Bump next to ^15.1.4 (mui#16150) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 2ee4a8f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:50:58 2025 +0200 Bump pnpm to 9.15.3 (mui#16151) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 89b0740 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:47:53 2025 +0200 Bump markdown-to-jsx to ^7.7.3 (mui#16149) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 3ac1a43 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:47:40 2025 +0200 Bump @octokit/plugin-retry to ^7.1.3 (mui#16140) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit d42a129 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:34:21 2025 +0200 Bump typescript to ^5.7.3 (mui#16152) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 8eaf601 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:31:00 2025 +0200 Bump jscodeshift to 17.1.2 (mui#16148) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit b216ad8 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:21:50 2025 +0200 Bump React (mui#16143) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 1a6dfc2 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:20:37 2025 +0200 Bump @tanstack/query-core to ^5.64.0 (mui#16154) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit eea3ad8 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:20:08 2025 +0200 Bump babel to ^7.26.5 (mui#16146) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 4cfb04c Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 09:19:20 2025 +0200 Bump @types/d3-shape to ^3.1.7 (mui#16141) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 8351f94 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 13 08:51:56 2025 +0200 Bump Material UI to ^5.16.14 (mui#16145) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 6b3dece Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 12 13:43:15 2025 +0000 Bump @octokit/rest to ^21.1.0 (mui#16153) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 41e5994 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 12 13:40:44 2025 +0000 Bump fast-glob to ^3.3.3 (mui#16147) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 71cdcbf Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 12 09:30:42 2025 +0000 Bump GitHub Actions (mui#16144) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit f07901e Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 12 09:28:32 2025 +0000 Bump @types/node to ^20.17.12 (mui#16142) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 49bee80 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 12 05:32:28 2025 +0000 Bump @next/eslint-plugin-next to 15.1.4 (mui#16139) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 3174216 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 12 05:31:35 2025 +0000 Bump @mui/monorepo digest to c51af8e (mui#16138) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 769855d Author: Jose C Quintas Jr <[email protected]> Date: Sat Jan 11 10:54:03 2025 +0100 [charts] Handle case where gradient stop `offset` could be `Infinite` (mui#16131) commit e93f4d2 Author: Rom Grk <[email protected]> Date: Fri Jan 10 17:25:27 2025 -0500 [DataGrid] Refactor: remove missed theme (mui#16122) commit 9c2224f Author: Jose C Quintas Jr <[email protected]> Date: Fri Jan 10 16:24:43 2025 +0100 [charts] Replace tooltip mark with style (mui#16117) commit 7d5dd73 Author: Jose C Quintas Jr <[email protected]> Date: Fri Jan 10 15:41:02 2025 +0100 [charts] Support `rtl` for gradient legend (mui#16115) commit d25c213 Author: Armin Mehinovic <[email protected]> Date: Fri Jan 10 14:30:29 2025 +0100 [docs] Fix demo rendering issue on Codesandbox (mui#16118) commit 1fdcf85 Author: Alexandre Fauquette <[email protected]> Date: Fri Jan 10 13:23:05 2025 +0100 [charts] Use plugin system for series and axes (mui#15865) Co-authored-by: Jose C Quintas Jr <[email protected]> commit 5999d29 Author: Jose C Quintas Jr <[email protected]> Date: Fri Jan 10 12:00:00 2025 +0100 [charts][docs] Fix wrong props warnings (mui#16119) commit 7541f95 Author: Armin Mehinovic <[email protected]> Date: Fri Jan 10 11:55:23 2025 +0100 [core] Type all references as `RefObject` (mui#16124) commit 85961a5 Author: Rom Grk <[email protected]> Date: Fri Jan 10 03:26:26 2025 -0500 [DataGrid] refactor: theme to CSS variables (mui#15704) Signed-off-by: Rom Grk <[email protected]> Co-authored-by: Kenan Yusuf <[email protected]> commit 9e07e0f Author: Flavien DELANGLE <[email protected]> Date: Fri Jan 10 09:18:12 2025 +0100 [pickers] Use context to pass props from the picker to the field (mui#16042) Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> commit 6412b8c Author: Armin Mehinovic <[email protected]> Date: Thu Jan 9 15:49:00 2025 +0100 v8.0.0-alpha.7 (mui#16110) Signed-off-by: Armin Mehinovic <[email protected]> Co-authored-by: Bilal Shafi <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]> commit 296a499 Author: Bilal Shafi <[email protected]> Date: Thu Jan 9 17:13:03 2025 +0500 [DataGridPremium] Server-side aggregation with data source (mui#15741) Co-authored-by: Armin Mehinovic <[email protected]> commit 3b0bba2 Author: Rom Grk <[email protected]> Date: Thu Jan 9 04:18:25 2025 -0500 [core] Update argos screenshots (mui#16111) commit 068ab78 Author: Andrew Cherniavskii <[email protected]> Date: Wed Jan 8 21:52:57 2025 +0100 [DataGridPremium] Improve aggregation performance for multiple columns (mui#16097) commit 3fe74a9 Author: Jose C Quintas Jr <[email protected]> Date: Wed Jan 8 16:18:31 2025 +0100 [charts] New HTML legend & styles (mui#15733) Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Alexandre Fauquette <[email protected]> commit 86d6e2a Author: Rom Grk <[email protected]> Date: Tue Jan 7 17:39:23 2025 -0500 [DataGrid] Refactor: create tooltip props (mui#16086) commit f1332f1 Author: Lukas Tyla <[email protected]> Date: Tue Jan 7 16:45:26 2025 +0200 [pickers] Rename `AdapterDateFns` into `AdapterDateFnsV2` and `AdapterDateFnsV3` into `AdapterDateFns` (mui#16082) Signed-off-by: Lukas Tyla <[email protected]> Co-authored-by: Michel Engelen <[email protected]> commit 0a7ba21 Author: Flavien DELANGLE <[email protected]> Date: Tue Jan 7 14:56:09 2025 +0100 [pickers] Always use `setValue` internally to update the picker value (mui#16056) commit cad579c Author: Flavien DELANGLE <[email protected]> Date: Tue Jan 7 12:35:24 2025 +0100 [pickers] Rename `ctx.onViewChange` to `ctx.setView` and add it to the actions context (mui#16044) commit 011ccd0 Author: Lukas Tyla <[email protected]> Date: Tue Jan 7 13:32:27 2025 +0200 [pickers] Memoize `<PickersActionBar />` (mui#16071) commit fb23fd1 Author: Lukas Tyla <[email protected]> Date: Tue Jan 7 12:53:00 2025 +0200 [l10n] Improve Norwegian (nb-NO) locale (mui#16083) (@josteinjhauge) (mui#16089) Signed-off-by: Jostein Hauge <[email protected]> Co-authored-by: Jostein Hauge <[email protected]> commit 0a8dff6 Author: tomashauser <[email protected]> Date: Tue Jan 7 09:23:10 2025 +0100 [docs] Fix non-existing "adapter" property of LocalizationProvider (mui#16084) commit 0f66a53 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 6 12:25:52 2025 +0200 Lock file maintenance (mui#16051) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 8e785f9 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 6 16:43:26 2025 +0700 Bump @mui/monorepo digest to 5d892ca (mui#16073) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 82cf0ed Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 6 11:20:02 2025 +0200 Bump markdownlint-cli2 to ^0.17.1 (mui#16079) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 5189633 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 6 11:15:50 2025 +0200 Bump concurrently to ^9.1.2 (mui#16078) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit b80d266 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 6 11:09:21 2025 +0200 Bump @tanstack/query-core to ^5.62.15 (mui#16074) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 7c41d42 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 6 11:04:23 2025 +0200 Bump styled-components to ^6.1.14 (mui#16080) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 0219cb4 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Jan 6 11:00:43 2025 +0200 Bump MUI Internal (mui#16077) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 5a267e7 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 5 04:43:34 2025 +0000 Bump @types/node to ^20.17.11 (mui#16076) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 959dc9d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Jan 5 04:42:38 2025 +0000 Bump @types/lodash to ^4.17.14 (mui#16075) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 3ebf4fb Author: Rom Grk <[email protected]> Date: Fri Jan 3 18:23:01 2025 -0500 [DataGrid] Refactor: create base button props (mui#15930) commit 513b8f6 Author: Lukas Tyla <[email protected]> Date: Fri Jan 3 15:37:59 2025 +0200 [pickers] Update `closeOnSelect` and `actionBar.actions` default values (mui#15944) Signed-off-by: Lukas Tyla <[email protected]> Co-authored-by: Arthur Balduini <[email protected]> Co-authored-by: arthurbalduini <[email protected]> commit 5f0cd45 Author: Armin Mehinovic <[email protected]> Date: Fri Jan 3 14:12:01 2025 +0100 [DataGrid] Fix number filter field formatting values while typing (mui#16062) commit d85fff1 Author: Jose C Quintas Jr <[email protected]> Date: Thu Jan 2 12:42:58 2025 +0100 [code-infra] Add `testSkipIf` and `describeSkipIf` (mui#16049) Signed-off-by: Jose C Quintas Jr <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> commit 3fffa77 Author: Steve Xu <[email protected]> Date: Thu Jan 2 17:25:40 2025 +0800 [l10n] Add Chinese (Taiwan) (zh-TW) locale (mui#16033) Signed-off-by: Steve Xu <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> commit 3b47f1d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Wed Jan 1 21:23:49 2025 +0700 Bump @mui/monorepo digest to 84d6ecf (mui#16021) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Lukas <[email protected]> commit 88438a1 Author: Lukas Tyla <[email protected]> Date: Wed Jan 1 14:25:27 2025 +0200 [test] Stabilize flaky Data Grid tests (mui#16053) commit a5f4a73 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Dec 31 14:55:55 2024 +0200 Bump MUI Internal (mui#16028) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 390211c Author: Rajat <[email protected]> Date: Tue Dec 31 17:53:50 2024 +0530 [docs] Fix `EditingWithDatePickers` demo (mui#15967) commit d570c6d Author: Andrew Cherniavskii <[email protected]> Date: Tue Dec 31 13:22:53 2024 +0100 [DataGrid] Fix TS error (mui#16046) commit 797c5a0 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Dec 31 13:57:37 2024 +0200 Bump next to ^15.1.3 (mui#16026) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 552f08b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Dec 31 13:57:00 2024 +0200 Bump @tanstack/query-core to ^5.62.9 (mui#16023) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 2f4af7e Author: Flavien DELANGLE <[email protected]> Date: Tue Dec 31 12:55:57 2024 +0100 [docs] Fix inconsistent multi input range field separators (mui#16043) commit f689693 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Tue Dec 31 13:55:29 2024 +0200 Bump pnpm to 9.15.2 (mui#16027) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit ea384f1 Author: Rajat <[email protected]> Date: Tue Dec 31 16:08:36 2024 +0530 [DataGridPremium] Make Aggregation keyboard accessible in the column menu (mui#15934) Co-authored-by: Bilal Shafi <[email protected]> commit 20e037b Author: Flavien DELANGLE <[email protected]> Date: Tue Dec 31 10:56:57 2024 +0100 [pickers] Introduce a new concept of `manager` (mui#15339) Signed-off-by: Flavien DELANGLE <[email protected]> Co-authored-by: Lukas Tyla <[email protected]> commit e5471d4 Author: Derek Alvarado <[email protected]> Date: Mon Dec 30 15:59:16 2024 -0700 [DataGrid] Add `name` attribute to selection checkboxes (mui#15178) Co-authored-by: Andrew Cherniavskii <[email protected]> commit 43411bf Author: Flavien DELANGLE <[email protected]> Date: Mon Dec 30 17:31:41 2024 +0100 [pickers] Create a new context to pass the range position props to the layout components and to the views (mui#15846) commit 9bce04c Author: Lukas Tyla <[email protected]> Date: Mon Dec 30 18:21:16 2024 +0200 [fields] Handle focusing container with `inputRef.current.focus` on `accessibleFieldDOMStructure` (mui#15985) commit 3ead503 Author: Andrew Cherniavskii <[email protected]> Date: Mon Dec 30 17:10:14 2024 +0100 [core] Update the `release:version` docs (mui#16038) commit 0c6aa25 Author: Flavien DELANGLE <[email protected]> Date: Mon Dec 30 16:27:38 2024 +0100 [pickers] Remove `NonEmptyDateRange` type (mui#16035) commit 2cc9bc8 Author: Flavien DELANGLE <[email protected]> Date: Mon Dec 30 16:26:21 2024 +0100 [docs] Unify the wording of the pickers slots breaking changes (mui#16036) commit e283172 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 30 17:04:59 2024 +0200 [core] Improve React 19 support (mui#15769) Signed-off-by: Armin Mehinovic <[email protected]> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Quintas <[email protected]> Co-authored-by: Lukas <[email protected]> Co-authored-by: flavien <[email protected]> Co-authored-by: Armin Mehinovic <[email protected]> Co-authored-by: Armin Mehinovic <[email protected]> Co-authored-by: Bilal Shafi <[email protected]> commit 89215a1 Author: Bilal Shafi <[email protected]> Date: Mon Dec 30 19:58:59 2024 +0500 [DataGrid] Fix select all checkbox state reset with server side data (mui#16034) commit 61346b3 Author: Flavien DELANGLE <[email protected]> Date: Mon Dec 30 10:14:59 2024 +0100 [pickers] Use `usePickerContext()` and `usePickerActionsContext()` instead of passing props to the `shortcuts` and `toolbar` slots (mui#15948) commit dac7c3d Author: Olivier Tassinari <[email protected]> Date: Sun Dec 29 13:22:12 2024 +0100 [core] Small fixes on docs commit 2fa4d4f Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 29 06:16:16 2024 +0000 Bump markdownlint-cli2 to ^0.17.0 (mui#16029) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 2c0a4a4 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 29 06:15:15 2024 +0000 Bump eslint-plugin-react to ^7.37.3 (mui#16025) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 7e7d63b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 29 04:56:05 2024 +0000 Bump concurrently to ^9.1.1 (mui#16024) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 25ae6e4 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 29 04:55:10 2024 +0000 Bump @next/eslint-plugin-next to 15.1.3 (mui#16022) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 7bc37b2 Author: Bilal Shafi <[email protected]> Date: Sat Dec 28 12:20:24 2024 +0500 [core] Clarify the release strategy (mui#16014) Co-authored-by: Andrew Cherniavskii <[email protected]> commit 2799763 Author: Lukas Tyla <[email protected]> Date: Fri Dec 27 18:06:40 2024 +0200 [pickers] Support `date-fns-jalali` v4 (mui#16011) commit dcdc59e Author: Lukas Tyla <[email protected]> Date: Fri Dec 27 15:07:37 2024 +0200 [docs] Refactor Data Grid with Date Pickers example (mui#15992) commit d8dbace Author: Olivier Tassinari <[email protected]> Date: Fri Dec 27 02:10:59 2024 +0100 [core] Sync with other repos commit 9c0c462 Author: Olivier Tassinari <[email protected]> Date: Fri Dec 27 01:28:01 2024 +0100 [docs] Fix 301 redirections Reported in https://app.ahrefs.com/site-audit/6021552/issues?current=25-12-2024T023235 commit 61d8511 Author: Danail Hadjiatanasov <[email protected]> Date: Thu Dec 26 22:13:45 2024 +0200 v8.0.0-alpha.6 (mui#16002) commit b061f55 Author: Lauri <[email protected]> Date: Thu Dec 26 10:13:55 2024 +0100 [data grid] Avoid subscribing to `renderContext` state in grid root for better scroll performance (mui#15986) commit 758d8b8 Author: Lukas Tyla <[email protected]> Date: Tue Dec 24 10:06:37 2024 +0200 [l10n] Improve Dutch (nl-NL) locale (mui#15920) @JoepVerkoelen (mui#15994) Signed-off-by: JoepVerkoelen <[email protected]> Co-authored-by: JoepVerkoelen <[email protected]> Co-authored-by: Joep Verkoelen <[email protected]> commit 4a649f2 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 17:47:28 2024 +0100 Bump @codspeed/vitest-plugin to ^4.0.0 (mui#15898) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Jose Quintas <[email protected]> commit a886d98 Author: Bilal Shafi <[email protected]> Date: Mon Dec 23 18:07:16 2024 +0500 [DataGrid] Improve test coverage of server side data source (mui#15942) commit f572940 Author: Rajat <[email protected]> Date: Mon Dec 23 18:27:07 2024 +0530 [DataGrid] Fix header filters showing clear button while empty (mui#15829) Co-authored-by: Armin Mehinovic <[email protected]> commit 26b1463 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 11:21:25 2024 +0200 Bump webpack-cli to ^6.0.1 (mui#15980) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit a7e6782 Author: Lauri <[email protected]> Date: Mon Dec 23 09:53:35 2024 +0100 [DataGrid] Replace `forwardRef` with a shim for forward compatibility (mui#15955) commit a58d118 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 10:07:10 2024 +0200 Bump pnpm to 9.15.1 (mui#15977) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 0a8efa4 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 10:06:57 2024 +0200 Bump React router to ^6.28.1 (mui#15974) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit ee83cad Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 09:45:24 2024 +0200 Bump react-hook-form to ^7.54.2 (mui#15978) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit ca29c58 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 09:41:48 2024 +0200 Bump markdown-to-jsx to ^7.7.2 (mui#15975) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 4b73330 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 09:40:59 2024 +0200 Bump @tanstack/query-core to ^5.62.8 (mui#15972) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 1d72f1a Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 09:40:27 2024 +0200 Bump @docsearch/react to ^3.8.2 (mui#15970) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit ae9c40b Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Mon Dec 23 09:27:14 2024 +0200 Bump next to ^15.1.2 (mui#15976) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 032c788 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 22 08:24:39 2024 +0000 Bump github/codeql-action action to v3.28.0 (mui#15979) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 9ab258d Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 22 08:20:03 2024 +0000 Bump @types/react to ^18.3.18 (mui#15973) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 0458ca5 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 22 04:28:13 2024 +0000 Bump @next/eslint-plugin-next to 15.1.2 (mui#15971) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 5e7eaa5 Author: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Date: Sun Dec 22 04:27:18 2024 +0000 Bump @mui/monorepo digest to 0ea1ef5 (mui#15969) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> commit 1bac67d Author: Rom Grk <[email protected]> Date: Fri Dec 20 18:03:58 2024 -0500 [DataGrid] Refactor: move skeleton to leaf import (mui#15931) commit f985ea0 Author: Lauri <[email protected]> Date: Fri Dec 20 23:48:32 2024 +0100 [docs] remove production profiler from docs build (mui#15959) commit 562675c Author: Rom Grk <[email protected]> Date: Fri Dec 20 17:43:15 2024 -0500 [DataGrid] Refactor: move progress components to leaf import (mui#15914) Signed-off-by: Rom Grk <[email protected]> Co-authored-by: Olivier Tassinari <[email protected]> Co-authored-by: Kenan Yusuf <[email protected]>

k-rajat19 commented Dec 10, 2024

View reviewed changes

packages/x-data-grid/src/components/panel/filterPanel/GridFilterInputValue.tsx Outdated Show resolved Hide resolved

k-rajat19 marked this pull request as ready for review December 10, 2024 13:11

k-rajat19 commented Dec 10, 2024

View reviewed changes

zannager added the component: data grid This is the name of the generic UI component, not the React module! label Dec 10, 2024

arminmeh added bug 🐛 Something doesn't work plan: Pro Impact at least one Pro user needs cherry-pick The PR should be cherry-picked to master after merge v7.x feature: Filtering on header Related to the header filtering (Pro) feature labels Dec 10, 2024

k-rajat19 force-pushed the issue-15778 branch 2 times, most recently from 92de0c8 to 4304555 Compare December 12, 2024 07:18

arminmeh force-pushed the issue-15778 branch from 6d984a7 to 8363581 Compare December 16, 2024 10:20

arminmeh reviewed Dec 16, 2024

View reviewed changes

arminmeh changed the title ~~[DataGrid] Fix Header filters do not clear properly when losing focus~~ [DataGrid] Fix Header filters showing clear button while empty Dec 16, 2024

arminmeh changed the title ~~[DataGrid] Fix Header filters showing clear button while empty~~ [DataGrid] Fix header filters showing clear button while empty Dec 16, 2024

arminmeh force-pushed the issue-15778 branch from 8363581 to 3063a4e Compare December 19, 2024 19:10

arminmeh requested review from KenanYusuf and MBilalShafi December 19, 2024 19:10

arminmeh force-pushed the issue-15778 branch 2 times, most recently from ba06c2b to 35c539d Compare December 20, 2024 13:02

arminmeh added the breaking change label Dec 20, 2024

arminmeh reviewed Dec 20, 2024

View reviewed changes

github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 23, 2024

MBilalShafi approved these changes Dec 23, 2024

View reviewed changes

k-rajat19 and others added 13 commits December 23, 2024 13:30

handle values

78ff45f

store previous operator in filter cache

7200f18

fix

6ffa625

optimize logic

d73acd2

test new way

b514128

Revert useGridColumnHeaders update

1f27dd4

Do not clear operator

079cb4b

Add types

d876991

Revert comment and spacing

7d37bb6

lint

82a8140

Lint for boolean sanitize function

2a2d04b

Keep sanitize fn exported

270950f

Remove util from the public API

1d992fa

arminmeh force-pushed the issue-15778 branch from bb1b286 to 1d992fa Compare December 23, 2024 12:40

github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Dec 23, 2024

arminmeh enabled auto-merge (squash) December 23, 2024 12:44

KenanYusuf disabled auto-merge December 23, 2024 12:45

KenanYusuf enabled auto-merge (squash) December 23, 2024 12:46

KenanYusuf merged commit f572940 into mui:master Dec 23, 2024
16 checks passed

arminmeh added a commit that referenced this pull request Dec 23, 2024

Manual cherry-pick of #15829

7015699

arminmeh mentioned this pull request Dec 23, 2024

[DataGrid] Fix header filters showing clear button while empty (@k-rajat19) #15990

Merged

k-rajat19 deleted the issue-15778 branch December 29, 2024 18:04

This was referenced Jan 2, 2025

[data grid] Impossible to type decimal numbers starting with .0 in the filter #16052

Closed

[DataGrid] Fix number filter field formatting values while typing #16062

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[DataGrid] Fix header filters showing clear button while empty #15829

[DataGrid] Fix header filters showing clear button while empty #15829

k-rajat19 commented Dec 10, 2024 •

edited by arminmeh

Loading

mui-bot commented Dec 10, 2024 •

edited

Loading

k-rajat19 Dec 10, 2024

romgrk Dec 16, 2024

k-rajat19 Dec 17, 2024 •

edited

Loading

arminmeh commented Dec 10, 2024

k-rajat19 commented Dec 11, 2024

k-rajat19 commented Dec 12, 2024

arminmeh commented Dec 13, 2024

arminmeh Dec 16, 2024

KenanYusuf Dec 16, 2024

arminmeh Dec 19, 2024

MBilalShafi Dec 20, 2024 •

edited

Loading

arminmeh Dec 20, 2024

MBilalShafi Dec 20, 2024 •

edited

Loading

KenanYusuf Dec 20, 2024

MBilalShafi Dec 20, 2024

arminmeh Dec 20, 2024 •

edited

Loading

MBilalShafi Dec 23, 2024

arminmeh Dec 20, 2024 •

edited

Loading

github-actions bot commented Dec 23, 2024

MBilalShafi left a comment

MBilalShafi Dec 23, 2024

github-actions bot commented Dec 23, 2024

[DataGrid] Fix header filters showing clear button while empty #15829

[DataGrid] Fix header filters showing clear button while empty #15829

Conversation

k-rajat19 commented Dec 10, 2024 • edited by arminmeh Loading

Changelog

Breaking changes

mui-bot commented Dec 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

k-rajat19 Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

arminmeh commented Dec 10, 2024

k-rajat19 commented Dec 11, 2024

k-rajat19 commented Dec 12, 2024

arminmeh commented Dec 13, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MBilalShafi Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MBilalShafi Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arminmeh Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

arminmeh Dec 20, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Dec 23, 2024

MBilalShafi left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Dec 23, 2024

k-rajat19 commented Dec 10, 2024 •

edited by arminmeh

Loading

mui-bot commented Dec 10, 2024 •

edited

Loading

k-rajat19 Dec 17, 2024 •

edited

Loading

MBilalShafi Dec 20, 2024 •

edited

Loading

MBilalShafi Dec 20, 2024 •

edited

Loading

arminmeh Dec 20, 2024 •

edited

Loading

arminmeh Dec 20, 2024 •

edited

Loading