Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support highlighting of separator lines between editor and breadcrumbs #125

Closed
arcticicestudio opened this issue Feb 15, 2020 · 0 comments · Fixed by #136
Closed

Support highlighting of separator lines between editor and breadcrumbs #125

arcticicestudio opened this issue Feb 15, 2020 · 0 comments · Fixed by #136
Labels
context-ui scope-compatibility scope-quality type-feature
Milestone
0.11.0

Comments

@arcticicestudio
Copy link
Contributor

arcticicestudio commented Feb 15, 2020 •
edited
Loading

Currently the the SEPARATOR_ABOVE_COLOR and SEPARATOR_BELOW_COLOR editor scheme keys, which were added to the IDE platform code in JetBrains/intellij-community@dda1191, are not defined explicitly which makes them inherit color values from other keys. They will be explicitly defined using nord3 as foreground color to ensure style consistency across IDE version updates.
@arcticicestudio arcticicestudio added this to the 0.11.0 milestone Feb 15, 2020
arcticicestudio added a commit that referenced this issue Feb 15, 2020
@arcticicestudio
Support highlighting of separator lines between editor and breadcrumbs
a23ec9c 
Previously the `SEPARATOR_ABOVE_COLOR` and `SEPARATOR_BELOW_COLOR`
editor scheme keys, which were added to the IDE platform code in
JetBrains/intellij-community@dda1191,
were not defined explicitly which makes them inherit color values from
other keys. They have now been explicitly defined using `nord3` as
foreground color to ensure style consistency across IDE version updates.

GH-125
@arcticicestudio arcticicestudio mentioned this issue Feb 15, 2020
Merged
arcticicestudio added a commit that referenced this issue Feb 15, 2020
@arcticicestudio
Support highlighting of separator lines between editor and bread… (#136)
3428e87 
Previously the `SEPARATOR_ABOVE_COLOR` and `SEPARATOR_BELOW_COLOR`
editor scheme keys, which were added to the IDE platform code in
JetBrains/intellij-community@dda1191,
were not defined explicitly which makes them inherit color values from
other keys. They have now been explicitly defined using `nord3` as
foreground color to ensure style consistency across IDE version updates.

Closes GH-125
arcticicestudio added a commit that referenced this issue Feb 15, 2020
@arcticicestudio
Support highlighting of separator lines between editor and bread… (#136)
febfdfe 
Previously the `SEPARATOR_ABOVE_COLOR` and `SEPARATOR_BELOW_COLOR`
editor scheme keys, which were added to the IDE platform code in
JetBrains/intellij-community@dda1191,
were not defined explicitly which makes them inherit color values from
other keys. They have now been explicitly defined using `nord3` as
foreground color to ensure style consistency across IDE version updates.

Closes GH-125
@Tom1206 Tom1206 mentioned this issue Feb 15, 2020
Closed
arcticicestudio added a commit that referenced this issue Feb 16, 2020
@arcticicestudio
Fix editor & breadcrumbs separator line color
114da0a 
Fixed the color of the editor & breadcrumbs separator line to use the
correct color `nord3` instead of the pinkish "test color" that should
only be used during development to quickly identify UI and syntax
elements that are affected by a specific theme color key.

Thanks to "Tom1206" again for the quick bug report.

[1]: https://github.com/Tom1206

Related to GH-125, GH-136
GH-138
arcticicestudio added a commit that referenced this issue Feb 16, 2020
@arcticicestudio
Fix editor & breadcrumbs separator line color (#139)
e029b55 
Fixed the color of the editor & breadcrumbs separator line to use the
correct color `nord3` instead of the pinkish "test color" that should
only be used during development to quickly identify UI and syntax
elements that are affected by a specific theme color key.

Thanks to "Tom1206" again for the quick bug report.

[1]: https://github.com/Tom1206

Related to GH-125, GH-136
Fixes GH-138
arcticicestudio added a commit that referenced this issue Feb 16, 2020
@arcticicestudio
Fix editor & breadcrumbs separator line color (#139)
ea887a6 
Fixed the color of the editor & breadcrumbs separator line to use the
correct color `nord3` instead of the pinkish "test color" that should
only be used during development to quickly identify UI and syntax
elements that are affected by a specific theme color key.

Thanks to "Tom1206" again for the quick bug report.

[1]: https://github.com/Tom1206

Related to GH-125, GH-136
Fixes GH-138
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui scope-compatibility scope-quality type-feature
Projects
None yet
Milestone
0.11.0
Development

Successfully merging a pull request may close this issue.

Support highlighting of separator lines between editor and breadcrumbs nordtheme/jetbrains
1 participant
@arcticicestudio