Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pink line between editor and breadcrumbs in 0.11.0 #138

Closed
Tom1206 opened this issue Feb 15, 2020 · 3 comments · Fixed by #139
Closed

Pink line between editor and breadcrumbs in 0.11.0 #138

Tom1206 opened this issue Feb 15, 2020 · 3 comments · Fixed by #139
Labels
context-ui type-bug
Milestone
0.11.1

Comments

@Tom1206
Copy link

Tom1206 commented Feb 15, 2020

Probably linked to #125 ?

Screenshot 2020-02-15 at 23 21 35
@Tom1206
Copy link
Author

Tom1206 commented Feb 15, 2020

It appears on WebStorm and PHPStorm, even after full plugin reinstallation and ide restart

@arcticicestudio arcticicestudio self-assigned this Feb 16, 2020
@arcticicestudio arcticicestudio added this to the Next milestone Feb 16, 2020
arcticicestudio added a commit that referenced this issue Feb 16, 2020
@arcticicestudio
Fix editor & breadcrumbs separator line color
114da0a 
Fixed the color of the editor & breadcrumbs separator line to use the
correct color `nord3` instead of the pinkish "test color" that should
only be used during development to quickly identify UI and syntax
elements that are affected by a specific theme color key.

Thanks to "Tom1206" again for the quick bug report.

[1]: https://github.com/Tom1206

Related to GH-125, GH-136
GH-138
@arcticicestudio arcticicestudio mentioned this issue Feb 16, 2020
Merged
@arcticicestudio
Copy link
Contributor

Thanks again for the report @Tom1206 👍
Looks like I've missed to adjust the "test color" before submitting #136 that I use to quickly identify UI and syntax elements that are affected by a specific theme color key 😒

arcticicestudio added a commit that referenced this issue Feb 16, 2020
@arcticicestudio
Fix editor & breadcrumbs separator line color (#139)
e029b55 
Fixed the color of the editor & breadcrumbs separator line to use the
correct color `nord3` instead of the pinkish "test color" that should
only be used during development to quickly identify UI and syntax
elements that are affected by a specific theme color key.

Thanks to "Tom1206" again for the quick bug report.

[1]: https://github.com/Tom1206

Related to GH-125, GH-136
Fixes GH-138
@arcticicestudio arcticicestudio removed their assignment Feb 16, 2020
arcticicestudio added a commit that referenced this issue Feb 16, 2020
@arcticicestudio
Fix editor & breadcrumbs separator line color (#139)
ea887a6 
Fixed the color of the editor & breadcrumbs separator line to use the
correct color `nord3` instead of the pinkish "test color" that should
only be used during development to quickly identify UI and syntax
elements that are affected by a specific theme color key.

Thanks to "Tom1206" again for the quick bug report.

[1]: https://github.com/Tom1206

Related to GH-125, GH-136
Fixes GH-138
@arcticicestudio
Copy link
Contributor

Released and deployed to the marketplace in version 0.11.1 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
context-ui type-bug
Projects
None yet
Milestone
0.11.1
Development

Successfully merging a pull request may close this issue.

Fix editor & breadcrumbs separator line color nordtheme/jetbrains
2 participants
@arcticicestudio @Tom1206