Support highlighting of separator lines between editor and breadcrumbs #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the `SEPARATOR_ABOVE_COLOR` and `SEPARATOR_BELOW_COLOR` editor scheme keys, which were added to the IDE platform code in JetBrains/intellij-community@dda1191, were not defined explicitly which makes them inherit color values from other keys. They have now been explicitly defined using `nord3` as foreground color to ensure style consistency across IDE version updates. GH-125
svengreb
approved these changes
Feb 15, 2020
arcticicestudio
deleted the
feature/gh-124-highlighting-separator-between-editor-breadcrumbs
branch
arcticicestudio
added a commit
that referenced
this pull request
Feb 15, 2020
Previously the `SEPARATOR_ABOVE_COLOR` and `SEPARATOR_BELOW_COLOR` editor scheme keys, which were added to the IDE platform code in JetBrains/intellij-community@dda1191, were not defined explicitly which makes them inherit color values from other keys. They have now been explicitly defined using `nord3` as foreground color to ensure style consistency across IDE version updates. Closes GH-125
arcticicestudio
added a commit
that referenced
this pull request
Feb 16, 2020
Fixed the color of the editor & breadcrumbs separator line to use the correct color `nord3` instead of the pinkish "test color" that should only be used during development to quickly identify UI and syntax elements that are affected by a specific theme color key. Thanks to "Tom1206" again for the quick bug report. [1]: https://github.com/Tom1206 Related to GH-125, GH-136 GH-138
arcticicestudio
added a commit
that referenced
this pull request
Feb 16, 2020
Fixed the color of the editor & breadcrumbs separator line to use the correct color `nord3` instead of the pinkish "test color" that should only be used during development to quickly identify UI and syntax elements that are affected by a specific theme color key. Thanks to "Tom1206" again for the quick bug report. [1]: https://github.com/Tom1206 Related to GH-125, GH-136 Fixes GH-138
arcticicestudio
added a commit
that referenced
this pull request
Feb 16, 2020
Fixed the color of the editor & breadcrumbs separator line to use the correct color `nord3` instead of the pinkish "test color" that should only be used during development to quickly identify UI and syntax elements that are affected by a specific theme color key. Thanks to "Tom1206" again for the quick bug report. [1]: https://github.com/Tom1206 Related to GH-125, GH-136 Fixes GH-138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #125