-
-
Notifications
You must be signed in to change notification settings - Fork 158
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use SequenceLike in geometry stubs #3212
Conversation
This PR and #3211 are standalones that are not blocked. Once these are merged I will update the dependent PRs to unblock them |
Yes, they are not blocked, but they block the PRs they were separated from. Which I feel defeats the point of splitting them out. |
Why not? These are two independent changes to the stubs. Changing all instances of Tuple, Dict, List to tuple, dict, list |
So whichever PR merges first will graciously let the second PR deal with the merge conflict. That's fine. |
Yeah but I do have a preference for this one being merged first because it's ready and small. The other one needs a push either way to address your other review comments |
I'm just saying the way you've set up these two PRs requires this to be merged first, when the changes are actually independent. I want to approve your other PR and not worry about this detail, let some geometry people take a look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I forgot to update this detail while porting them, thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
Separated out from #3143 for independent review