Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMAKE --build issue #55

Closed
derekneves opened this issue Oct 30, 2024 · 2 comments · Fixed by #56
Closed

CMAKE --build issue #55

derekneves opened this issue Oct 30, 2024 · 2 comments · Fixed by #56

Comments

@derekneves
Copy link

snippet of Dockerfile used (using same dev env dockerfile as in rippled documentation)

RUN git clone https://github.com/ripple/validator-keys-tool.git && cd validator-keys-tool && git checkout master
WORKDIR /root/validator-keys-tool
RUN conan profile new default --detect
RUN conan profile update settings.compiler.libcxx=libstdc++11 default
RUN conan remote add ripple http://18.143.149.228:8081/artifactory/api/conan/conan-non-prod
RUN mkdir .build
WORKDIR /root/validator-keys-tool/.build
RUN conan install .. --output-folder . --build missing
RUN cmake -DCMAKE_POLICY_DEFAULT_CMP0091=NEW -DCMAKE_TOOLCHAIN_FILE:FILEPATH=conan_toolchain.cmake -DCMAKE_BUILD_TYPE=Release ..

Issue occurs here

RUN cmake --build .

ERROR

root@c3a5ec476012:~/validator-keys-tool/.build# cmake --build .
[ 20%] Building CXX object CMakeFiles/validator-keys.dir/src/ValidatorKeys.cpp.o
In file included from /root/validator-keys-tool/src/ValidatorKeys.cpp:21:
/root/validator-keys-tool/src/ValidatorKeys.h:21:10: fatal error: xrpl/protocol/KeyType.h: No such file or directory
21 | #include <xrpl/protocol/KeyType.h>
| ^~~~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
gmake[2]: *** [CMakeFiles/validator-keys.dir/build.make:76: CMakeFiles/validator-keys.dir/src/ValidatorKeys.cpp.o] Error 1
gmake[1]: *** [CMakeFiles/Makefile2:111: CMakeFiles/validator-keys.dir/all] Error 2
gmake: *** [Makefile:101: all] Error 2

conan profile

root@c3a5ec476012:~/validator-keys-tool/.build# conan profile show default
Configuration for profile default:

[settings]
os=Linux
os_build=Linux
arch=x86_64
arch_build=x86_64
compiler=gcc
compiler.version=11
compiler.libcxx=libstdc++11
build_type=Release
[options]
[conf]
[build_requires]
[env]

building on m1 (ARM) in docker using --platform=linux/amd64 flag in dockerfile

@derekneves
Copy link
Author

Unrelated but would help me out, is there supposed to be a precompiled binary of the validator-keys-tool in the deb and rpm packages ? Following the documentation I do not see it installed after rippled is installed via apt/deb

@ximinez
Copy link
Contributor

ximinez commented Oct 30, 2024

See #56 , which I just opened to address this issue.

ximinez added a commit that referenced this issue Nov 4, 2024
* The rest of the code was updated in #54 (89ab7e5) to allow for
  a combined build for the next version of rippled. Unfortunately, this
  broke the standalone build. Point conan at the latest beta so the
  build can work.
* This will need to be updated again after rippled 2.3 is released.
* Resolves #55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants