Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TRIVIAL] Update xrpl version to fix standalone build #56

Merged
merged 1 commit into from
Nov 4, 2024
Merged

[TRIVIAL] Update xrpl version to fix standalone build #56

merged 1 commit into from
Nov 4, 2024

Conversation

ximinez
Copy link
Contributor

@ximinez ximinez commented Oct 30, 2024 •
edited
Loading

  • The rest of the code was updated in Changes required due to libxrpl refactor #54 (89ab7e5) to allow for a combined build for the next version of rippled. Unfortunately, this broke the standalone build. Point conan at the latest beta so the build can work.
  • This will need to be updated again after rippled 2.3 is released.

Resolves #55

@ximinez
Update xrpl version to fix standalone build
cbc494d 
* The rest of the code was updated in ripple#54 (89ab7e5) to allow for
  a combined build for the next version of rippled. Unfortunately, this
  broke the standalone build. Point conan at the latest beta so the
  build can work.
* This will need to be updated again after rippled 2.3 is released.
@ximinez ximinez mentioned this pull request Oct 30, 2024
Closed
@ximinez ximinez merged commit 811e2f6 into ripple:master Nov 4, 2024
1 check failed
@ximinez ximinez deleted the conan_build_fix branch November 4, 2024 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thejohnfreeman thejohnfreeman thejohnfreeman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CMAKE --build issue
2 participants
@ximinez @thejohnfreeman