Pull actively info-applying functions out of rz_core_bin_info() #742
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #742 +/- ##
==========================================
- Coverage 42.80% 42.79% -0.01%
==========================================
Files 871 871
Lines 316703 316711 +8
==========================================
- Hits 135554 135546 -8
- Misses 181149 181165 +16
Continue to review full report at Codecov.
|
thestr4ng3r
changed the title
thestr4ng3r
requested review from
kazarmy,
ret2libc,
wargio and
XVilka
as code owners
| // use our internal values for va | ||
| va = va ? VA_TRUE : VA_FALSE; | ||
|
|
||
| rz_core_bin_apply_strings(r, binfile); |
There was a problem hiding this comment.
This is all the code that rz_core_bin_info(r, RZ_CORE_BIN_ACC_ALL, NULL, RZ_MODE_SET, va, NULL, NULL), which was there before was calling. The plan is to make it into individual functions rz_core_bin_apply_*() per info type and only for applying info, while rz_core_bin_info() will only do printing.
There was a problem hiding this comment.
Ah, YES! If this is to split the set and the printing, then yes please :)
thestr4ng3r
force-pushed
the
bin-info-set
branch
from
64ca429 to
1e5e557
Compare
| static bool bin_raw_strings(RzCore *r, PJ *pj, int mode, int va); | ||
| static int bin_info(RzCore *r, PJ *pj, int mode, ut64 laddr); | ||
| static int bin_main(RzCore *r, PJ *pj, int mode, int va); | ||
| static int bin_dwarf(RzCore *core, PJ *pj, int mode); |
There was a problem hiding this comment.
Would it be possible to sort this list somehow?
There was a problem hiding this comment.
Yes, but these declarations are also only temporary until the are all unfolded and refactored.
thestr4ng3r
force-pushed
the
bin-info-set
branch
from
1e5e557 to
97d0536
Compare
|
minstr/maxstr/filter is missing in apply_strings, putting this to draft again until I figured out how to do that best without code duplication. |
|
It looks good. In the future we might consider to split |
|
@thestr4ng3r if you're refactoring, may as well use the table API to have the ability to sort per column etc. 👍 |
|
Table API is a good idea, but should be done seperately. |
No description provided.