Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pull Applying Bin Config and Main out of rz_core_bin_info() #775

Merged
merged 4 commits into from
Mar 6, 2021

Conversation

thestr4ng3r
Copy link
Member

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the rizin book with the relevant information (if needed)

Detailed description

Follow-up to #742

@thestr4ng3r thestr4ng3r changed the title Pull Applying Bin Config out of rz_core_bin_info() Pull Applying Bin Config and Main out of rz_core_bin_info() Mar 5, 2021
@codecov
Copy link

codecov bot commented Mar 5, 2021

Codecov Report

Merging #775 (f00eea7) into dev (8269a24) will increase coverage by 0.02%.
The diff coverage is 92.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     rizinorg/rizin#775      +/-   ##
==========================================
+ Coverage   42.78%   42.81%   +0.02%     
==========================================
  Files         871      871              
  Lines      316898   316914      +16     
==========================================
+ Hits       135579   135676      +97     
+ Misses     181319   181238      -81     
Impacted Files Coverage Δ
librz/core/cbin.c 85.79% <92.64%> (-0.08%) ⬇️
librz/bin/bfile.c 88.46% <100.00%> (-0.02%) ⬇️
librz/bin/bin.c 70.48% <100.00%> (-0.14%) ⬇️
librz/bin/bobj.c 86.87% <100.00%> (+0.04%) ⬆️
librz/io/p/io_gdb.c 35.96% <0.00%> (-5.89%) ⬇️
shlr/gdb/src/packet.c 55.35% <0.00%> (-5.36%) ⬇️
librz/bp/bp_io.c 88.46% <0.00%> (-3.85%) ⬇️
shlr/gdb/src/gdbclient/xml.c 62.76% <0.00%> (-1.51%) ⬇️
librz/debug/debug.c 54.48% <0.00%> (-0.39%) ⬇️
librz/socket/socket.c 23.95% <0.00%> (-0.35%) ⬇️
... and 8 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8269a24...f00eea7. Read the comment docs.

librz/bin/bobj.c Outdated Show resolved Hide resolved
RZ_API RzList *rz_bin_get_sections(RzBin *bin);
RZ_API RzList *rz_bin_get_classes(RzBin *bin);
RZ_API RzList *rz_bin_get_strings(RzBin *bin);
RZ_API RZ_DEPRECATE RzList *rz_bin_get_entries(RzBin *bin);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thestr4ng3r thestr4ng3r requested a review from XVilka March 6, 2021 10:00
@thestr4ng3r thestr4ng3r merged commit fbeb51b into dev Mar 6, 2021
@thestr4ng3r thestr4ng3r deleted the bin-refactor branch March 6, 2021 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants