Separate Relocs Setting and Printing #938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thestr4ng3r
force-pushed
the
apply-relocs
branch
from
1696fd0 to
3234ec4
Compare
thestr4ng3r
requested review from
kazarmy,
ret2libc,
wargio and
XVilka
as code owners
ret2libc
approved these changes
Apr 2, 2021
| char *mn = rz_bin_demangle(r->bin->cur, NULL, name, addr, keep_lib); | ||
| if (mn) { | ||
| RBNode *relocs = NULL; | ||
| if (r->bin->cur && r->bin->cur->o) { |
There was a problem hiding this comment.
if possible without too much hassle, please extract all the inner code in a separate function because having such a long if is painful for my eyes :D
wargio
requested changes
Apr 2, 2021
thestr4ng3r
force-pushed
the
apply-relocs
branch
from
9abe9bc to
68f5ed0
Compare
|
split now |
XVilka
approved these changes
Apr 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #880, #775, #742