Warn about Visual Studio Code branding confusion #102577
Conversation
rustbot
added
the
T-compiler
|
r? @nagisa (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
I believe what we actually need is just the build tools, which, if we spelled out would possibly remove the ambiguity as well (“Visual Studio Build Tools” seems less confusable with “VS Code” than “Visual Studio” is) either way, somebody working with Windows should review this (me guesses the command is…) @rustbot ping windows |
|
Hey Windows Group! This bug has been identified as a good "Windows candidate". cc @arlosi @ChrisDenton @danielframpton @gdr-at-ms @kennykerr @luqmana @lzybkr @nico-abram @retep998 @rylev @sivadeilra @wesleywiser |
|
r? @wesleywiser |
|
This change seems reasonable though I agree adding "build tools" is a good further clarification (here's a link to downloading those - though I wouldn't include the link in the message). It may help to also say "not to be confused with VS Code" instead of "not VS Code" as it sounds sort of like we're telling the user not to download VS Code when instead we mean that for this purpose we're not referring to VS Code. |
kornelski
force-pushed
the
non-code-visual-studio
branch
from
5f86873 to
080ad53
Compare
|
I've updated the text |
This comment has been minimized.
This comment has been minimized.
|
I think the changed text looks reasonable. I wouldn't want to emphasise Build Tools too much due to the current licensing situation (it requires a Community, Professional or Enterprise license) but I'm fine with it simply being listed as an option. |
This comment has been minimized.
This comment has been minimized.
kornelski
force-pushed
the
non-code-visual-studio
branch
from
5f499fe to
bf5db9d
Compare
This comment has been minimized.
This comment has been minimized.
kornelski
force-pushed
the
non-code-visual-studio
branch
from
bf5db9d to
9b3db34
Compare
|
Thanks @kornelski! @bors r+ |
bors
added
S-waiting-on-bors
|
@bors rollup |
…r=wesleywiser Warn about Visual Studio Code branding confusion VS Code is a popular companion for Rust, but Microsoft's branding is confusing, and users [may not understand](https://users.rust-lang.org/t/complie-error-when-i-run-rustc/82127) they also need the *other* VS.
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#102577 (Warn about Visual Studio Code branding confusion) - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…) - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`) - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`) - rust-lang#102748 (Disable compressed debug sections on i586-gnu) - rust-lang#102761 (let-else: test else block with non-never uninhabited type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
VS Code is a popular companion for Rust, but Microsoft's branding is confusing, and users may not understand they also need the other VS.