Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not reverse the expected type and found type for ObligationCauseCo… #102720

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

lyming2007
Copy link

…de of IfExpressionWithNoElse

this will fix #102397

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @compiler-errors (or someone else) soon.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 5, 2022
@compiler-errors
Copy link
Member

I guess this is fine.

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Oct 6, 2022

📌 Commit 0501d61 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 6, 2022
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Oct 7, 2022
…piler-errors

do not reverse the expected type and found type for ObligationCauseCo…

…de of IfExpressionWithNoElse

this will fix rust-lang#102397
bors added a commit to rust-lang-ci/rust that referenced this pull request Oct 7, 2022
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#102577 (Warn about Visual Studio Code branding confusion)
 - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…)
 - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`)
 - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`)
 - rust-lang#102748 (Disable compressed debug sections on i586-gnu)
 - rust-lang#102761 (let-else: test else block with non-never uninhabited type)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 047ff20 into rust-lang:master Oct 7, 2022
@rustbot rustbot added this to the 1.66.0 milestone Oct 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"if may be missing an else clause" sometimes reverses expectations
5 participants