-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable compressed debug sections on i586-gnu #102748
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Compressed debug is enabled by default for gas (assembly) on Linux/x86 targets, and we started building our own in rust-lang#102530, but that made our `compiler_builtins` incompatible with binutils < 2.32. Add an explicit option to disable that in our crosstool-ng config. Fixes rust-lang#102703.
rustbot
added
the
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
label
Oct 6, 2022
(rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Oct 6, 2022
@bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Oct 6, 2022
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Oct 7, 2022
…troalbini Disable compressed debug sections on i586-gnu Compressed debug is enabled by default for gas (assembly) on Linux/x86 targets, and we started building our own in rust-lang#102530, but that made our `compiler_builtins` incompatible with binutils < 2.32. Add an explicit option to disable that in our crosstool-ng config. Fixes rust-lang#102703.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Oct 7, 2022
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#102577 (Warn about Visual Studio Code branding confusion) - rust-lang#102720 (do not reverse the expected type and found type for ObligationCauseCo…) - rust-lang#102744 (rustdoc: remove unused CSS `.content .item-list`) - rust-lang#102747 (rustdoc: remove unused CSS `.docblock a:not(.srclink)`) - rust-lang#102748 (Disable compressed debug sections on i586-gnu) - rust-lang#102761 (let-else: test else block with non-never uninhabited type) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-infra
Relevant to the infrastructure team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compressed debug is enabled by default for gas (assembly) on Linux/x86
targets, and we started building our own in #102530, but that made our
compiler_builtins
incompatible with binutils < 2.32. Add an explicitoption to disable that in our crosstool-ng config. Fixes #102703.