⬆️ rust-analyzer #112305

lnicola · 2023-06-05T09:07:08Z

…kril feat: Closure capture inlay hints I opted for a fictional `move(foo, &bar, &mut qux)` syntax here, disabled by default as these are not correct rust syntax and hence could cause confusion. ![image](https://user-images.githubusercontent.com/3757771/236447484-649a4ea6-ad61-496e-bad8-765a5236150e.png)

Fix manual formatting and remove duplicate command

minor: Hide deps panel outside of Rust projects and set missing category Closes rust-lang#14760

More APIs for `la_arena::IdxRange` ```rust impl<T> ExactSizeIterator for IdxRange<T>; impl<T> Arena<T> { pub fn alloc_many<II: IntoIterator<Item = T>>(&mut self, iter: II) -> IdxRange<T>; } ``` 1. There are no currently ways to get `IdxRange` without manually offseting `Idx`. Providing a method for multiple-allocation simplifies this process and makes it less error-prone. 2. `IdxRange: ExactSizeIterator` makes `iter.zip(range).rev()` possible. Since `Zip: DoubleEndedIterator` requires all its arguments to be `ExactSizeIterator`. It also ease the usage for, eg. `len()`. 3. Fixed a typo. I noticed that `IdxRange::end` may be invalid. Is it good to return `Idx` instead of `RawIdx`?

…dentation no longer

Add basic support for `augmentsSyntaxTokens` and non-standard semantic token config cc rust-lang#12783 Closes rust-lang/rust-analyzer#13066

We've already removed non-sysroot proc macro server, which effectively removed support for Rust <1.64.0, so this removal of fallback path shouldn't be problem at this point.

…=Veykril Introduce macro sub-namespaces and `macro_use` prelude This PR implements two mechanisms needed for correct macro name resolution: macro sub-namespace and `macro_use` prelude. - [macro sub-namespaces][subns-ref] Macros have two sub-namespaces: one for function-like macro and the other for those in attributes (including custom derive macros). When we're resolving a macro name for function-like macro, we should ignore non-function-like macros, and vice versa. This helps resolve single-segment macro names because we can (and should, as rustc does) fallback to names in preludes when the name in the current module scope is in different sub-namespace. - [`macro_use` prelude][prelude-ref] `#[macro_use]`'d extern crate declarations (including the standard library) bring their macros into scope, but they should not be prioritized over local macros (those defined in place and those explicitly imported). We have been bringing them into legacy (textual) macro scope, which has the highest precedence in name resolution. This PR introduces the `macro_use` prelude in crate-level `DefMap`s, whose precedence is lower than local macros but higher than the standard library prelude. The first 3 commits are drive-by fixes/refactors. Fixes rust-lang#8828 (prelude) Fixes rust-lang#12505 (prelude) Fixes rust-lang#12734 (prelude) Fixes rust-lang#13683 (prelude) Fixes rust-lang#13821 (prelude) Fixes rust-lang#13974 (prelude) Fixes rust-lang#14254 (namespace) [subns-ref]: https://doc.rust-lang.org/reference/names/namespaces.html#sub-namespaces [prelude-ref]: https://doc.rust-lang.org/reference/names/preludes.html#macro_use-prelude

Use double reference in debug derive fix rust-lang#14768

fix: Add macro modifier for highlighting tokens in macro calls Followup to rust-lang/rust-analyzer#14777 we have to tell the client about the semantic tokens inside macro calls as those can be remapped. Adding a modifier will force this behavior.

rustbot · 2023-06-05T09:07:17Z

Some changes occurred in src/tools/rust-analyzer

cc @rust-lang/rust-analyzer

lnicola · 2023-06-05T09:08:04Z

@bors r+ p=1

bors · 2023-06-05T09:08:06Z

📌 Commit b8a7d43 has been approved by lnicola

It is now in the queue for this repository.

lnicola · 2023-06-05T09:15:11Z

@bors r-

lnicola · 2023-06-05T09:23:55Z

@Veykril we don't have that feature in crates/rust-analyzer/Cargo.toml, but the test works fine on our side. Maybe you can spot what's wrong?

Urgau · 2023-06-05T10:01:36Z

The feature was removed in rust-lang/rust-analyzer@c21860b#diff-520e21205f2074cf2309045ac5b868b4fbf2192fe75ff249aa287e01d183bf8c but the gated test was not removed or adjusted. Hope this helps.

Veykril · 2023-06-05T11:41:25Z

Oh that was a mistake, the feature should've stayed there I think. The test is still wanted.

Bring back sysroot-abi feature rust-lang#112305

…m-ra

lnicola · 2023-06-05T12:17:23Z

@bors r+ p=1

bors · 2023-06-05T12:17:25Z

📌 Commit 6c1f108 has been approved by lnicola

It is now in the queue for this repository.

bors · 2023-06-05T13:31:14Z

⌛ Testing commit 6c1f108 with merge 2f896da...

bors · 2023-06-05T16:50:25Z

☀️ Test successful - checks-actions
Approved by: lnicola
Pushing 2f896da to master...

rust-timer · 2023-06-05T18:05:22Z

Finished benchmarking commit (2f896da): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.2%	[0.7%, 1.8%]	16
Regressions ❌ (secondary)	2.5%	[2.5%, 2.5%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.2%	[0.7%, 1.8%]	16

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.8%, 0.8%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.8%	[0.8%, 0.8%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 646.59s -> 646.24s (-0.05%)

Veykril and others added 30 commits May 8, 2023 09:50

Render places in capture inlay hints

4c5fd19

Fix broken table

b632c7d

Fix formatting

10637cf

Remove duplicate command

053741c

Auto merge of rust-lang#14763 - lnicola:dep-tree-fixes, r=lnicola

aaed89a

Fix manual formatting and remove duplicate command

Hide deps panel outside of Rust projects and set missing category

f8477d0

Auto merge of rust-lang#14764 - lnicola:deps-fixes-2, r=lnicola

c26a43d

minor: Hide deps panel outside of Rust projects and set missing category Closes rust-lang#14760

Prepare tidy.rs

d4b668a

Add doc(alias)-based method completion

2a182f3

generate_derive no longer breaks indentation

a0db478

add_missing_impl_members no longer breaks indentation

e07d638

add_missing_impl_members and add_missing_default_members break in…

49f1092

…dentation no longer

Add basic support for augmentsSyntaxTokens

4b42acf

Add config for disabling non standard lsp highlight tokens

91d5a68

Auto merge of rust-lang#14777 - rust-lang:highlight, r=Veykril

b069eb7

Add basic support for `augmentsSyntaxTokens` and non-standard semantic token config cc rust-lang#12783 Closes rust-lang/rust-analyzer#13066

Refactor

a0a7860

fix: column!() and line!() built-in macros return u32

34a9129

Remove prelude fallback path for Rust <1.52.0

96113b7

We've already removed non-sysroot proc macro server, which effectively removed support for Rust <1.64.0, so this removal of fallback path shouldn't be problem at this point.

Add macro_use prelude to DefMap

3203ea8

Consider macro sub-namespace during name resolution

f2a35de

Use double reference in debug derive

7da80d4

Auto merge of rust-lang#14788 - HKalbasi:derive-impl-f, r=Veykril

884dd8c

Use double reference in debug derive fix rust-lang#14768

MIR episode 5

cbcafd3

Restructure InlayHint, no longer derive properties from its kind

730286b

Simplify bind pat filtering

edd60f7

Add macro modifier for highlighting tokens in macro calls

8e11685

rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 5, 2023

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2023

This comment has been minimized.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 5, 2023

lnicola marked this pull request as draft June 5, 2023 09:52

Add back sysroot-abi feature gate to rust-analyzer

768a6c5

lnicola mentioned this pull request Jun 5, 2023

internal: Bring back sysroot-abi feature rust-lang/rust-analyzer#14984

Merged

bors and others added 2 commits June 5, 2023 11:54

Auto merge of rust-lang#14984 - lnicola:rm-test-gate, r=Veykril

ed87e0a

Bring back sysroot-abi feature rust-lang#112305

Merge commit 'ed87e0a20a9d196a5ea659ea46ae9574be666d4f' into sync-fro…

6c1f108

…m-ra

lnicola marked this pull request as ready for review June 5, 2023 12:17

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 5, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 5, 2023

bors merged commit 2f896da into rust-lang:master Jun 5, 2023

rustbot added this to the 1.72.0 milestone Jun 5, 2023

lnicola deleted the sync-from-ra branch June 5, 2023 16:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⬆️ rust-analyzer #112305

⬆️ rust-analyzer #112305

lnicola commented Jun 5, 2023

rustbot commented Jun 5, 2023

lnicola commented Jun 5, 2023

bors commented Jun 5, 2023

This comment has been minimized.

lnicola commented Jun 5, 2023

lnicola commented Jun 5, 2023

Urgau commented Jun 5, 2023

Veykril commented Jun 5, 2023

lnicola commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

rust-timer commented Jun 5, 2023

⬆️ rust-analyzer #112305

⬆️ rust-analyzer #112305

Conversation

lnicola commented Jun 5, 2023

rustbot commented Jun 5, 2023

lnicola commented Jun 5, 2023

bors commented Jun 5, 2023

This comment has been minimized.

lnicola commented Jun 5, 2023

lnicola commented Jun 5, 2023

Urgau commented Jun 5, 2023

Veykril commented Jun 5, 2023

lnicola commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

bors commented Jun 5, 2023

rust-timer commented Jun 5, 2023

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size