Check lazy type aliases for well-formedness #114228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
fmease
commented
Jul 29, 2023
fmease
commented
Jul 29, 2023
compiler/rustc_lint/src/builtin.rs
Outdated
| || ty.has_opaque_types() | ||
| || ty.has_inherent_projections() | ||
| { | ||
| // Bounds of lazy type aliases and on eager ones that contain opaque types or inherent |
There was a problem hiding this comment.
Let me know if the phrasing is ok, bounds sounds ambiguous to me. One might wonder it refers to the bounds on the generic parameters (which is the case) or if it refers to the item bounds (i.e. the B in type T: B = … which is obviously invalid for type aliases).
|
Update: Done. |
fmease
force-pushed
the
wf-lazy-ty-aliases
branch
from
aaf9e2d to
4308ce6
Compare
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
fmease
force-pushed
the
wf-lazy-ty-aliases
branch
from
4308ce6 to
fc41ee0
Compare
|
☔ The latest upstream changes (presumably #114226) made this pull request unmergeable. Please resolve the merge conflicts. |
fmease
force-pushed
the
wf-lazy-ty-aliases
branch
from
fc41ee0 to
0ca4328
Compare
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 31, 2023
…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#114111 (Improve test case for experimental API remove_matches) - rust-lang#114169 (refactor builtin unsize handling, extend comments) - rust-lang#114182 (clean up after 113312) - rust-lang#114193 (Update lexer emoji diagnostics to Unicode 15.0) - rust-lang#114200 (Detect trait upcasting through struct tail unsizing in new solver select) - rust-lang#114228 (Check lazy type aliases for well-formedness) - rust-lang#114267 (Map RPITIT's opaque type bounds back from projections to opaques) - rust-lang#114269 (Migrate GUI colors test to original CSS color format) - rust-lang#114286 (Add missing feature gate in multiple_supertrait_upcastable doc) r? `@ghost` `@rustbot` modify labels: rollup
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we didn't check if
T: Mulholds given lazytype Alias<T> = <T as Mul>::Output;.Now we do. It only makes sense.
@rustbot label F-lazy_type_alias
r? @oli-obk