This repository has been archived by the owner on May 18, 2021. It is now read-only.
Calculate OktaClient Content-Length correctly #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the content length was being calculated based off of an empty uninitialised byte array. With this change it's now calculated off of the actual data array used as the body. Setting the content length to 0 seemed to be causing an issue with recent changes to Okta's infrastructure as noticed in segmentio#298.
Chippiewill
changed the title
|
Yes it does, I came up with this fix before seeing #299 |
|
Wow, such a simple mistake. @nickatsegment confirmed, just this patch, without #298 fixes the issue in our environment. I'm guessing the HTTP1 server implementation handles the 0 Content-Length, while the HTTP2 implementation is stricter, and won't read any more of the POST packet because we said it was 0. |
|
We may also want to be explicit on the NextProto, but I'd love to get just this fix into an official 1.0.5 version to unblock my users ASAP. |
|
@sdann awesome. Will get it merged ASAP |
nickatsegment
approved these changes
Sep 30, 2020
nickatsegment
changed the title
arohter
pushed a commit
to TiVo/aws-okta
that referenced
this pull request
Nov 21, 2020
arohter
added a commit
to TiVo/aws-okta
that referenced
this pull request
Nov 21, 2020
This reverts commit e93f247.
arohter
added a commit
to TiVo/aws-okta
that referenced
this pull request
Nov 21, 2020
* Revert "disable github releases (currently broken) (segmentio#305)" This reverts commit b5cad3b. * Revert "Added Ubuntu 2020 (Focal) to Makefile.release (segmentio#304)" This reverts commit ac21803. * Revert "Fix cred process expiration (segmentio#303)" This reverts commit 90c0192. * Revert "Update issue templates" This reverts commit 9e17974. * Revert "Calculate OktaClient Content-Length correctly (segmentio#300)" This reverts commit e93f247.
arohter
added a commit
to TiVo/aws-okta
that referenced
this pull request
Nov 21, 2020
* Calculate OktaClient Content-Length correctly (segmentio#300) Fixes: segmentio#298 * Update issue templates * Fix cred process expiration (segmentio#303) * Added Ubuntu 2020 (Focal) to Makefile.release (segmentio#304) * disable github releases (currently broken) (segmentio#305) Co-authored-by: Will Gardner <[email protected]> Co-authored-by: Nick Irvine <[email protected]> Co-authored-by: Zoltán Reegn <[email protected]> Co-authored-by: Yossi Eliaz <[email protected]>
|
Had a few Segmenters mention that they required this fix after coming back from vacation today, and that they were using v1.0.4 successfully up until then. Strange. |
arohter
added a commit
to TiVo/aws-okta
that referenced
this pull request
Feb 19, 2021
* Calculate OktaClient Content-Length correctly (segmentio#300) Fixes: segmentio#298 * Update issue templates * Fix cred process expiration (segmentio#303) * Added Ubuntu 2020 (Focal) to Makefile.release (segmentio#304) * disable github releases (currently broken) (segmentio#305) * Update AWS Go SDK To v1.25.35 (segmentio#307) Fixes STS regional endpoint support. * Add STS Regional Endpoint Support To Other STS Clients (segmentio#308) * Update keyring to v1.1.6 (segmentio#309) Recent versions of kwallet have removed the old support for the kde4 compatible kwallet dbus interface. This means newer kde5 based OS installs (e.g. kubuntu 20.04) can no longer use the kwallet backend with aws-okta. This was fixed upstream in the keyring lib back in 2019 but the dependency hasn't been bumped since then. Co-authored-by: Will Gardner <[email protected]> Co-authored-by: Nick Irvine <[email protected]> Co-authored-by: Zoltán Reegn <[email protected]> Co-authored-by: Yossi Eliaz <[email protected]> Co-authored-by: Andrew Babichev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the content length was being calculated based off of an empty
uninitialised byte array. With this change it's now calculated off of the
actual data array used as the body.
Setting the content length to 0 seemed to be causing an issue with
recent changes to Okta's infrastructure as noticed in #298.