This repository has been archived by the owner on May 18, 2021. It is now read-only.
Update keyring to v1.1.6 #309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Recent versions of kwallet have removed the old support for the kde4 compatible kwallet dbus interface. This means newer kde5 based OS installs (e.g. kubuntu 20.04) can no longer use the kwallet backend with aws-okta. This was fixed upstream in the keyring lib back in 2019 but the dependency hasn't been bumped since then.
|
I'm gonna consider this a "ship it and see" merge. If it breaks anybody, we'll immediately revert. |
arohter
added a commit
to TiVo/aws-okta
that referenced
this pull request
Feb 19, 2021
* Calculate OktaClient Content-Length correctly (segmentio#300) Fixes: segmentio#298 * Update issue templates * Fix cred process expiration (segmentio#303) * Added Ubuntu 2020 (Focal) to Makefile.release (segmentio#304) * disable github releases (currently broken) (segmentio#305) * Update AWS Go SDK To v1.25.35 (segmentio#307) Fixes STS regional endpoint support. * Add STS Regional Endpoint Support To Other STS Clients (segmentio#308) * Update keyring to v1.1.6 (segmentio#309) Recent versions of kwallet have removed the old support for the kde4 compatible kwallet dbus interface. This means newer kde5 based OS installs (e.g. kubuntu 20.04) can no longer use the kwallet backend with aws-okta. This was fixed upstream in the keyring lib back in 2019 but the dependency hasn't been bumped since then. Co-authored-by: Will Gardner <[email protected]> Co-authored-by: Nick Irvine <[email protected]> Co-authored-by: Zoltán Reegn <[email protected]> Co-authored-by: Yossi Eliaz <[email protected]> Co-authored-by: Andrew Babichev <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recent versions of kwallet have removed the old support for the kde4
compatible kwallet dbus interface. This means newer kde5 based
OS installs (e.g. kubuntu 20.04) can no longer use the kwallet backend
with aws-okta.
This was fixed upstream in the keyring lib back in 2019 but the
dependency hasn't been bumped since then.