Skip to content
This repository has been archived by the owner on May 18, 2021. It is now read-only.

Add STS Regional Endpoint Support To Other STS Clients #308

Merged

Conversation

Tensho
Copy link
Contributor

@Tensho Tensho commented Dec 28, 2020

Follow up to #307.

STS clients are created in multiple places with the lack of STS regional endpoint configuration. The required option was added to all of them. Also, I've tested the entire workflow with aws-okta exec command call + enabled HTTP request to debug logging and now everything looks good:

...
DEBU[0006] Step 4: Assume Role with SAML
DEBU[0006] Using region: us-east-1
2020/12/28 15:58:59 DEBUG: Request sts/AssumeRoleWithSAML Details:
---[ REQUEST POST-SIGN ]-----------------------------
POST / HTTP/1.1
Host: sts.us-east-1.amazonaws.com
...
DEBU[0007] Using session 3QFD, expires in 59m58.959948s
2020/12/28 15:59:01 DEBUG: Request sts/GetCallerIdentity Details:
---[ REQUEST POST-SIGN ]-----------------------------
POST / HTTP/1.1
Host: sts.us-east-1.amazonaws.com
...

@fh-jinoa
Copy link

does documentation need to be updated to allow for overrides of the default value?

@Tensho
Copy link
Contributor Author

Tensho commented Dec 28, 2020

This is just a bugfix. I don't think any documentation should be updated.

@Tensho
Copy link
Contributor Author

Tensho commented Dec 29, 2020

@nickatsegment Would you mind to check this stuff?

@nickatsegment
Copy link
Contributor

I'm on the fence as to whether this sort of thing is really a bugfix or not, but luckily it's super simple so I'm just going to defer that decision and merge with reckless abandon. Must be the 2021 spirit

@nickatsegment nickatsegment merged commit 5959494 into segmentio:master Jan 4, 2021
arohter added a commit to TiVo/aws-okta that referenced this pull request Feb 19, 2021
* Calculate OktaClient Content-Length correctly (segmentio#300)

Fixes: segmentio#298

* Update issue templates

* Fix cred process expiration (segmentio#303)

* Added Ubuntu 2020 (Focal) to Makefile.release (segmentio#304)

* disable github releases (currently broken) (segmentio#305)

* Update AWS Go SDK To v1.25.35 (segmentio#307)

Fixes STS regional endpoint support.

* Add STS Regional Endpoint Support To Other STS Clients (segmentio#308)

* Update keyring to v1.1.6 (segmentio#309)

Recent versions of kwallet have removed the old support for the kde4
compatible kwallet dbus interface. This means newer kde5 based
OS installs (e.g. kubuntu 20.04) can no longer use the kwallet backend
with aws-okta.

This was fixed upstream in the keyring lib back in 2019 but the
dependency hasn't been bumped since then.

Co-authored-by: Will Gardner <[email protected]>
Co-authored-by: Nick Irvine <[email protected]>
Co-authored-by: Zoltán Reegn <[email protected]>
Co-authored-by: Yossi Eliaz <[email protected]>
Co-authored-by: Andrew Babichev <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants