[#285] Bump text package after 2.0.1 (to 2.0.2)
#283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Martoon-00 this PR won't be needed until |
|
Right. This information seems not actual at the moment of me answering though, since even |
Martoon-00
force-pushed
the
martoon/bump-text-after-2.0.1
branch
from
a4cbd8b
to
8049813
Compare
|
I'm not really sure whether commenting out the badges is what we want - when we make a release they won't be excluded from Hackage until the next release 🤔 |
Problem: after `2.0.1` version they rewrote `pack` completely, so now our tricks with folding `pack`/`unpack`'s internals do not work. For details, see [this commit in `text` package](haskell/text@5a666e4). Fortunately, annihilating entire `pack` and `unpack` calls is still an option. Along with that `pack` rewrite they added `NOINLINE [0]` pragma for `pack`, meaning that we have even better chances of the rewrite rule to fire. Solution: add a `MIN_VERSION` pragma to disable the now non-working rewrite rule in the recent `text` versions. Rely on the remaining `unpack (pack s) = s` and `pack (unpack s) = s` rewrite rules to fire at stage 0. Update maintenance notes, in the new reality verifying whether `text` bump is correct should be simpler.
Problem: after the last commit it is safe to allow the recent `text-2.0.2`. Solution: allow it.
Problem: universum was excluded from the LTS, and xrefcheck complains on badges containing invalid links. Solution: comment those badges out, create a ticket for restoring the things.
Martoon-00
force-pushed
the
martoon/bump-text-after-2.0.1
branch
from
a26f6ad
to
70292d3
Compare
Closed
lierdakil
reviewed
Jun 23, 2023
Martoon-00
changed the title
text package after 2.0.1text package after 2.0.1 (to 2.0.2)
lierdakil
approved these changes
Jun 23, 2023
gromakovsky
approved these changes
Jun 23, 2023
Problem: after the large rewrite of `text` package (where it started keeping UTF-8 instead of UTF-16) some things changed. E.g. the code point mentioned in the comment is different now, and the link to the `text`'s source code is not more actual. Solution: strip the details that has to be maintained. It all seems pretty clear without them.
Martoon-00
changed the title
text package after 2.0.1 (to 2.0.2)text package after 2.0.1 (to 2.0.2)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In the current
master(after2.0.1version)textpackage changes implementation ofpack, and this affects which rewrite rules should we use. After the new release, these and maybe some other changes will have to be applied.Related issues(s)
Resolves #285
✓ Checklist for your Pull Request
Ideally a PR has all of the checkmarks set.
If something in this list is irrelevant to your PR, you should still set this
checkmark indicating that you are sure it is dealt with (be that by irrelevance).
are inextricably linked. Otherwise I should open multiple PR's.
I checked whether these changes impact the
.hlint.yamlrulesand updated them if needed.
Related changes (conditional)
Tests
silently reappearing again.
Documentation
I checked whether I should update the docs and did so if necessary:
Record your changes
and
Stylistic guide (mandatory)
My commit history is clean (only contains changes relating to my
issue/pull request and no reverted-my-earlier-commit changes) and commit
messages start with identifiers of related issues in square brackets.
Example:
[#42] Short commit descriptionIf necessary both of these can be achieved even after the commits have been
made/pushed using rebase and squash.
✓ Release Checklist
universum.cabal.under the "Unreleased" section to a new section for this release version.
I added
@sincehaddock annotations.with a summary of all user-facing changes.
vX.Y.Z