Windows build updates #1575
Merged
Windows build updates #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
force-pushed
the
windows-build-updates
branch
from
c67929c to
38677bc
Compare
By using an older version of rust to build the artifacts on windows. Alternatively we could build separate artifacts for windows 7, and continue using the latest version of rust for later versions of windows that are more optimized for more recent versions. Fixes: sharkdp#1550
tmccombs
force-pushed
the
windows-build-updates
branch
from
38677bc to
7042dff
Compare
tavianator
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continue supporting windows 7 with builds
By using an older version of rust to build the artifacts on windows.
Alternatively we could build separate artifacts for windows 7, and
continue using the latest version of rust for later versions of windows
that are more optimized for more recent versions.
Fixes: #1550