Implements the editor title in RN for Gutenberg #9027
Conversation
…ss-Android into gutenberg/post-title-in-rn * 'develop' of https://github.com/wordpress-mobile/WordPress-Android: (41 commits) CircleCI: Use explicit Gradle options to prevent out of memory errors Avoid using content resolver to get valid mime type, instead use UrlUtils.getUrlMimeType() Replace ellipsis with colon Update Aztec reference to v1.3.16 Add newline to tests Update the GB mobile ref to point to merged commit Keep tab selection in Stats Update the GB mobile ref Update the GB mobile ref Update the GB mobile ref Update the GB mobile ref Update the GB mobile ref Point to GB mobile with JitPack workaround Update release notes Removed duplicated dots from image URL alpha-149 / 671 version bump 11.6-rc-4 / 670 version bump Don't use React Native's version of okhttp3 Align non-english text in stats to right Remove layoutDirection ...
| return mWPAndroidGlueCode.getTitle(new OnGetContentTimeout() { | ||
| @Override public void onGetContentTimeout(InterruptedException ie) { | ||
| AppLog.e(T.EDITOR, ie); | ||
| Thread.currentThread().interrupt(); |
There was a problem hiding this comment.
While I can see this has been copied from getContent(), I have to say this caught my attention and had to do some reading about it. TIL.
There was a problem hiding this comment.
Nice work here @daniloercoli and @diegoreymendez !
Tested on the given scenarios and verified all works well on a couple emulators and a handset.
Small thing, when the title is focused, you can still tap on the undo/redo arrows and these work on the block immediately below, like it's focused.
Steps to reproduce:
- start a new draft
- write a title
- also enter some text in the body
- tap on the title to focus on it and observe the cursor appears there
- tap on undo, observe the block below changes its contents to whatever it had before
- tap on redo, observe it again operates on the block below the title.
I've tested Gutenberg on the web and what you do on the title affects the undo/redo history as well, so I think we may want to reflect that behavior here, but I think it's perfectly fine to leave it for a different PR / set of PRs.
Looks good to me! 
|
@mzorz, @daniloercoli - I've added an item to make sure we implement undo / redo for the title in this issue: wordpress-mobile/gutenberg-mobile#372 We can spawn more specific issues off that one if needed. I'd say if possible, let's synch to merge this @daniloercoli, so we can move on the remaining tasks. |
…ss-Android into gutenberg/post-title-in-rn * 'develop' of https://github.com/wordpress-mobile/WordPress-Android: (521 commits) Add a unit test to verify non-mobile segments are filtered out Remove an unintended release note addition which was most likely caused by a merge Update ref to point to merged commit in master Remote post conflict resolution uses OnPostChanged Post reference for conflict resolution dialog nullified early Simplify the undo logic for keeping local version of conflicted post Point gutenberg-mobile to release/v0.3.4 bump aztec version to v1.3.18 (#9103) Add NEW_SITE_CREATION_ENABLED build flag Revert add site creation to release-notes.xml Revert some changes from "Clean up NewSiteCreationBaseFormFragment" Revert "Switch to the new site creation flow" Revert "Remove classes and resources related to old site creation flow" Revert "Remove jumpToNewPost method which isn't used in new site creation flow" Revert "Remove unused resources related to old site creation flow" updated to latest GB mobile hash Fix bug in NewSiteCreationService - service started multiple times moved initialization of helper classes to onCreate() Update GB Hash Add action that commits the changes in the metadata strings files ... # Conflicts: # libs/editor/WordPressEditor/build.gradle
Description:
Implements the editor title in RN for Gutenberg, also removes the native title.
Related PRs:
gutenberg: WordPress/gutenberg#13199
gutenberg-mobile: wordpress-mobile/gutenberg-mobile#450
Testing:
Test 1:
Make sure the post title has been udpated.
Test 2:
Make sure the post title hasn't changed.
Test 3:
Make sure the placeholder shows up and the title is empty.
Test 4:
Make sure pressing ENTER does not insert a newline. We will add the correct behavior on a separate PR.