Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use RichText component on Title block #513

Merged
merged 34 commits into from
Feb 5, 2019

Conversation

daniloercoli
Copy link
Contributor

@daniloercoli daniloercoli commented Jan 28, 2019

This PR fixes #502 and moves forward #372 by making the title block working fine with the Enter.Key pressed event.
On Enter.Key pressed event, the Keyboard is not dismissed anymore and you can keep writing into the next block.

GB-side PR: WordPress/gutenberg#13548

To test:

  • Start the mobile demo app
  • Put the caret somewhere in the Title block
  • Tap enter on the soft keyboard, or on the hw keyboard
  • It should add a new empty (para) block after the Title

Note
With this PR the styling of the Title block is lost, we will re-add it back on a separate PR when the iOS side of AztecWrapper will support styling. See this PR here: wordpress-mobile/react-native-aztec#114

@daniloercoli daniloercoli added the [Type] Enhancement Improves a current area of the editor label Jan 28, 2019
…rg-mobile into issue/372-move-title-to-rich-text

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  Updates the gutenberg reference.
  Update gutenberg submodule (#509)
  Updates the GB reference.
  Uses the global store for the post title and adds undo/redo support.

# Conflicts:
#	gutenberg
daniloercoli and others added 19 commits January 30, 2019 16:49
…rg-mobile into issue/372-move-title-to-rich-text

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  Added missing react method signature (#523)
  passing mediaId in onMediaSelected (#521)
  v0.3.4
  Update GB bundle.
  Refactor name of MediaSource to avoid name collision on the main app.
  Update Gutenberg reference.
  refactor media upload methods to be inline with JS and iOS
  Refactor names of helper methods.
  Change media upload sync method.
  Implement enum using strings to simplify conversion logic.
  Remove whitespace
  Refactor method name to make it more obvious the intent.
  Refactor bridge media protocol methods to a single method.
  Merge branch 'develop' into feature/media_upload_methods_refactor
  Refactor media upload names to more consistent names.
  Removes border from title and changes the placeholder text.
  passing null to onImageQueryReattach() on Android
  Implement reattach of events on iOS.
  Add the ability to set font family, weight, size, and style from RN
  Recommend using the gutenberg-mobile repo

# Conflicts:
#	gutenberg
…rg-mobile into issue/372-move-title-to-rich-text

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile: (41 commits)
  Update gutenberg ref to master
  Update gutenberg ref
  Update gutenberg ref to Master
  Update gutenberg ref
  Update gutenberg ref
  Make uploads to be successful.
  Making sure we will only send a 32 bits number for the media to avoid conversion issues to JS.
  Implement media actions.
  Update gutenberg ref
  Update gutenberg ref
  Split media pick logic from media upload logic.
  Updated gutenberg submodule
  Updated gutenberg submodule
  Add methods to track ongoing and failed uploads.
  Updated gutenberg sumodule
  Updated gutenberg submodule
  Refactor save to file to separate method.
  Implement iOS new GB bridge methods for media options.
  Updated gutenberg submodule
  Update gutenberg ref
  ...
Remap font names for iOS for PR 372.
daniloercoli and others added 3 commits February 5, 2019 16:48
…rg-mobile into issue/372-move-title-to-rich-text

* 'develop' of https://github.com/wordpress-mobile/gutenberg-mobile:
  Make heading styling distinguishable from paragraph (#525)
  Point to merged Aztec commit
  Setup Aztec to not autofocus when visible
  Refocus the last focused item after reattaching
  Update gutenberg ref to master
  Update gutenberg ref
  Fix some issues from merge
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Update gutenberg ref
  Move callbacks closer to Gutenberg fragment
  No need to specially set title/content for new post
  Update android bridge code after merged from develop
  Ability to attach ReactRootView to different Activity

# Conflicts:
#	gutenberg
Copy link
Contributor

@diegoreymendez diegoreymendez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-tested everything and it seems like this is good to go.

Good (collaborative) work!

@diegoreymendez diegoreymendez merged commit 74731fd into develop Feb 5, 2019
@diegoreymendez diegoreymendez deleted the issue/372-move-title-to-rich-text branch February 5, 2019 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle pressing Enter.key on title in RN
2 participants