Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes border from title and changes the placeholder text. #515

Merged
merged 1 commit into from
Jan 29, 2019

Conversation

diegoreymendez
Copy link
Contributor

Description:

Removes the border from the title and changes the placeholder text to match what's described here.

Closes #372

Testing:

Test 1:

Make sure the title has no bottom border.

Test 2:

Remove the title from the demo and make sure the placeholder reads "Add a Title".

Test 3:

  1. Edit the title
  2. Switch to HTML and back.

Make sure the edits are properly persisted.

@diegoreymendez diegoreymendez added the [Type] Enhancement Improves a current area of the editor label Jan 28, 2019
@diegoreymendez diegoreymendez added this to the Beta milestone Jan 28, 2019
@diegoreymendez diegoreymendez self-assigned this Jan 28, 2019
@iamthomasbishop
Copy link
Contributor

One quick little thing I noticed when playing w/ the latest Alpha – can we set the text color of the placeholder label to $gray aka #87a6bc – same as the other placeholder text? TY in advance!

@daniloercoli
Copy link
Contributor

Styling of the Title block needs to be re-worked when we migrate the Title block to use RichText.
(We can't re-use the current CSS declarations, instead we will need to move most of the declarations to props at Component level).
There is a PR open for the migration to RichText, so I guess we can migrate it, and then fix all the styling issues in another PR. #513

@diegoreymendez
Copy link
Contributor Author

@daniloercoli - The bottom border needs to be removed anyway... so unless there's a strong reason not to merge this I'd still go ahead.

@daniloercoli
Copy link
Contributor

Sorry, I meant to reply to @iamthomasbishop :)
This PR is fine to merge!

@diegoreymendez
Copy link
Contributor Author

Thanks @daniloercoli !

@diegoreymendez diegoreymendez merged commit 8e376f5 into develop Jan 29, 2019
@diegoreymendez diegoreymendez deleted the issue/372-title-improvements branch January 29, 2019 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Enhancement Improves a current area of the editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants