Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFT changes #335

Merged
merged 20 commits into from
Feb 7, 2023
Merged

NFT changes #335

merged 20 commits into from
Feb 7, 2023

Conversation

devyetii
Copy link
Contributor

@devyetii devyetii commented Dec 14, 2022 •
edited
Loading

A brief description of the changes in this PR:

  • User can control access to new allocations
  • User can see the new fields added to the allocation
  • Depend on new gosdk version

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@devyetii devyetii linked an issue Dec 14, 2022 that may be closed by this pull request
NFT changes #149
Closed
@devyetii
Copy link
Contributor Author

devyetii commented Dec 14, 2022 •
edited
Loading

requires 0chain/gosdk#687 to be merged

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 828-nft-restrict-file-access-options
authorizer staging
0box 828-nft-restrict-file-access-options
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain staging
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk staging
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@devyetii devyetii requested review from Sriep and cnlangzi January 24, 2023 21:02
@devyetii devyetii requested a review from dabasov February 1, 2023 06:40
@devyetii devyetii mentioned this pull request Feb 1, 2023
Merged
3 tasks
@devyetii devyetii changed the title WIP NFT changes NFT changes Feb 1, 2023
@devyetii devyetii requested a review from peterlimg February 2, 2023 19:32
@devyetii
Copy link
Contributor Author

devyetii commented Feb 2, 2023

@dabasov @peterlimg Kindly review and merge after 0chain/gosdk#687 as it depends on that branch. Unit tests are failing bcz of these dependencies and will be successful when it's merged.

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [cancelled] with the following config

config value
tests skipped FALSE
system-tests master
gosdk 686-add-fields-to-allocation-to-support-nft
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk NOT OVERRIDDEN
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

dabasov
dabasov approved these changes Feb 3, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@devyetii devyetii requested a review from dabasov February 4, 2023 12:20
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests 398-new-system-test-for-nft-allocation-features
gosdk NOT OVERRIDDEN
zboxcli 149-nft-changes
zwalletcli staging
0chain 828-nft-restrict-file-access-options
blobber 476-toggle-permission-to-uploaddelete-update-move-copy-and-rename
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

dabasov
dabasov approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped true
system-tests master
gosdk staging
zboxcli 149-nft-changes
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov
Copy link
Member

dabasov commented Feb 7, 2023

successful run https://github.com/0chain/0chain/actions/runs/4116598014/jobs/7106843538

@dabasov dabasov merged commit e035377 into staging Feb 7, 2023
@cnlangzi cnlangzi deleted the 149-nft-changes branch February 15, 2023 10:24
peterlimg added a commit that referenced this pull request Feb 16, 2023
@peterlimg
Merge branch 'staging' into chain-fee
975f711 
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
peterlimg added a commit that referenced this pull request Feb 16, 2023
@peterlimg
Merge branch 'staging' into chain-fee
4dd977d 
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
peterlimg added a commit that referenced this pull request Feb 19, 2023
@peterlimg
Merge branch 'staging' into chain-fee
35d0933 
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dabasov dabasov dabasov approved these changes

@Sriep Sriep Awaiting requested review from Sriep

@cnlangzi cnlangzi Awaiting requested review from cnlangzi

@peterlimg peterlimg Awaiting requested review from peterlimg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

NFT changes
3 participants
@devyetii @service-0chain @dabasov