Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove allocation name #346

Merged
merged 13 commits into from
Feb 7, 2023
Merged

Remove allocation name #346

merged 13 commits into from
Feb 7, 2023

Conversation

areebusmani
Copy link
Contributor

@areebusmani areebusmani commented Jan 29, 2023

A brief description of the changes in this PR:

Tasks to complete before merging PR:

  • Ensure system tests are passing. If not Run them manually to check for any regressions 📋
  • Do any new system tests need added to test this change? do any existing system tests need updated? If so create a PR at 0chain/system_test
  • Merge your system tests PR to master AFTER merging this PR

Associated PRs (Link as appropriate):

@areebusmani areebusmani changed the title Remove allocation name [Draft] Remove allocation name Jan 29, 2023
@areebusmani areebusmani changed the title [Draft] Remove allocation name Remove allocation name Jan 29, 2023
@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli areeb/allocname
zwalletcli staging
0chain staging
blobber staging
authorizer smart-contract-areeb
0box areeb/allocname
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli areeb/allocname
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box areeb/allocname
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk NOT OVERRIDDEN
zboxcli areeb/allocname
zwalletcli staging
0chain smart-contract-areeb
blobber staging
authorizer staging
0box areeb/allocname
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@areebusmani areebusmani requested a review from dabasov January 30, 2023 14:55
@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests smart-contract-areeb
gosdk NOT OVERRIDDEN
zboxcli areeb/allocname
zwalletcli staging
0chain smart-contract-areeb
blobber staging
authorizer staging
0box areeb/allocname
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests smart-contract-areeb
gosdk NOT OVERRIDDEN
zboxcli areeb/allocname
zwalletcli staging
0chain smart-contract-areeb
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer master
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped FALSE
system-tests master
gosdk areeb/allocname
zboxcli areeb/allocname
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@service-0chain
Copy link
Contributor

Manual system tests [failure] with the following config

config value
tests skipped FALSE
system-tests smart-contract-areeb
gosdk NOT OVERRIDDEN
zboxcli areeb/allocname
zwalletcli staging
0chain smart-contract-areeb
blobber staging
authorizer staging
0box areeb/allocname
0block staging
0dns staging
explorer master
0proxy staging
0search staging

Copy link
Member

@dabasov dabasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@service-0chain
Copy link
Contributor

Manual system tests [success] with the following config

config value
tests skipped true
system-tests master
gosdk staging
zboxcli areeb/allocname
zwalletcli staging
0chain staging
blobber staging
authorizer staging
0box staging
0block staging
0dns staging
explorer staging
0proxy staging
0search staging

@dabasov dabasov merged commit 2a765b9 into staging Feb 7, 2023
@areebusmani areebusmani deleted the areeb/allocname branch February 8, 2023 05:17
peterlimg added a commit that referenced this pull request Feb 16, 2023
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
peterlimg added a commit that referenced this pull request Feb 16, 2023
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
peterlimg added a commit that referenced this pull request Feb 19, 2023
* staging:
  update gosdk to staging
  Fix incorrect timestamp convert
  Update gosdk
  debugged
  made common.TimeStamp to time.Time for stakedAt
  converted StakedAt to time.Time
  Fix/file options not supported by some sdk clients (#353)
  Remove allocation name (#346)
  NFT changes (#335)
  clean up: collab command
  fix(listall): fixed json output (#348)
  upgrade GoSDK to v1.8.12 (#349)
  fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342)
  feat(list): exported created_at and updated_at (#345)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants