-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/exposed time list all #345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
cnlangzi
force-pushed
the
feat/exposed_time_list_all
branch
from
January 29, 2023 02:26
b738654
to
b02737f
Compare
Manual system tests [failure] with the following config
|
boddumanohar
approved these changes
Jan 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
cnlangzi
force-pushed
the
feat/exposed_time_list_all
branch
from
January 30, 2023 01:09
dbcf086
to
b02737f
Compare
Manual system tests [success] with the following config
|
peterlimg
added a commit
that referenced
this pull request
Feb 16, 2023
* staging: update gosdk to staging Fix incorrect timestamp convert Update gosdk debugged made common.TimeStamp to time.Time for stakedAt converted StakedAt to time.Time Fix/file options not supported by some sdk clients (#353) Remove allocation name (#346) NFT changes (#335) clean up: collab command fix(listall): fixed json output (#348) upgrade GoSDK to v1.8.12 (#349) fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342) feat(list): exported created_at and updated_at (#345)
peterlimg
added a commit
that referenced
this pull request
Feb 16, 2023
* staging: update gosdk to staging Fix incorrect timestamp convert Update gosdk debugged made common.TimeStamp to time.Time for stakedAt converted StakedAt to time.Time Fix/file options not supported by some sdk clients (#353) Remove allocation name (#346) NFT changes (#335) clean up: collab command fix(listall): fixed json output (#348) upgrade GoSDK to v1.8.12 (#349) fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342) feat(list): exported created_at and updated_at (#345)
peterlimg
added a commit
that referenced
this pull request
Feb 19, 2023
* staging: update gosdk to staging Fix incorrect timestamp convert Update gosdk debugged made common.TimeStamp to time.Time for stakedAt converted StakedAt to time.Time Fix/file options not supported by some sdk clients (#353) Remove allocation name (#346) NFT changes (#335) clean up: collab command fix(listall): fixed json output (#348) upgrade GoSDK to v1.8.12 (#349) fix(zcncore): used zcncore.MakeSCRestAPICall instead of zboxutil.Make… (#342) feat(list): exported created_at and updated_at (#345)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
created_at
andupdated_at
onlist-all
Fixes
Tests
Tasks to complete before merging PR:
Associated PRs (Link as appropriate):