-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ReleasePrep][2021.08.03]RI of dev into main #8734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses #8602 Co-authored-by: Sophia Favro <[email protected]>
* Feature flag added for npe. * Added view models for npe. * Old npe code deleted. * NPE link added on display page. * Update DisplayPackageV2 with npe changes. * Added test cases for npe and fuget links and can display method. * Fix FakeFeatureFlagService.
This change re-adds support for the `#show-readme-container` fragment link generated by the V3 API. I also fixed some ARIA attributes to improve accessibility. Addresses #8698
* Move package query logic to AdminControllerBase * Refactor DeleteSearchResult to PackageSearchResult * Add bulk listed update service using same logic as deprecation * Add UpdateListedController * Add select listed/unlist
Addresses #8613
Lighthouse is a tool to check a website follows best practices: https://developers.google.com/web/tools/lighthouse Category | Score before | Score after | Change -- | -- | -- | -- Performance | 100 | 100 | - Accessibility | 96 | 100 | +4 Best practices | 80 | 87 | +7 SEO | 91 | 100 | +9 Addresses #8605
Add a banner that links to a preview of the redesign. Once on the preview, you see a banner to take a survey. Addresses #8672
Fixes a few bugs found while preparing for the bug bash: 1. Show all versions for a package 2. Don't show the "Used by" tag on .NET Tools or if the feature is disabled 3. Removed the repeated `Dependencies` heading if a package's dependencies could not be processed Part of: #8606
Fixes a few problems. Addresses #8719 1. Prevent README images from overflow. 2. Fix Bootstrap grid to add gutter and avoid an unnecessary scroll bar 3. Improve the installation instructions scrollbar
[ReleasePrep][2021.08.03]FI of master/main into dev
zhhyu
requested review from
joelverhagen,
agr,
loic-sharma,
ryuyu and
dannyjdev
August 4, 2021 00:33
zhhyu
changed the title
[ReleasePrep][2021.08.03]RI of dev into master/main
[ReleasePrep][2021.08.03]RI of dev into main
Aug 4, 2021
joelverhagen
approved these changes
Aug 4, 2021
@dannyjdev - could you verify Loic's changes on DEV? |
ryuyu
approved these changes
Aug 4, 2021
loic-sharma
approved these changes
Aug 4, 2021
dannyjdev
approved these changes
Aug 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.